Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Audit: Archives #9280

Closed
1 of 2 tasks
kjellr opened this issue Aug 23, 2018 · 10 comments
Closed
1 of 2 tasks

Block Audit: Archives #9280

kjellr opened this issue Aug 23, 2018 · 10 comments
Assignees
Labels
[Block] Archives Affects the Archives Block [Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@kjellr
Copy link
Contributor

kjellr commented Aug 23, 2018

Note: We'll be doing these audits in waves and editing this as we work through the blocks, so this text will be updated and fleshed out as we progress. See the full picture here.

Overview

screen shot 2018-08-23 at 12 22 24 pm

Name: Archives
Description: Display a monthly archive of your site’s Posts.
*Category: Widgets
CSS class: None
Can be converted to: Nothing

States

Empty/Selected/Placeholder

screen shot 2018-08-23 at 12 22 21 pm

Unselected:

screen shot 2018-08-23 at 12 25 39 pm

Primary (toolbar) settings

Align Left, Align Center, Align Right

Secondary (sidebar) settings

Archives Settings: Show Post Counts, Display as Dropdown

Frontend appearance

Gutenberg Starter Theme

screen shot 2018-08-23 at 12 30 37 pm

Atomic Blocks

screen shot 2018-08-23 at 12 36 11 pm

twentyseventeen

screen shot 2018-08-23 at 12 37 41 pm

twentyten

screen shot 2018-08-23 at 12 38 19 pm

Bugs/errors

Individual issues will be opened for these soon

Suggestions

Individual issues will be opened for these soon

@kjellr kjellr added [Type] Task Issues or PRs that have been broken down into an individual action to take [Feature] Blocks Overall functionality of blocks labels Aug 23, 2018
@kjellr kjellr self-assigned this Aug 23, 2018
@ZebulanStanphill
Copy link
Member

It would be really nice if the Archives, Categories, and Latest Posts blocks all supported custom post types. That is probably out-of-scope for WordPress 5.0, but it would definitely be a nice addition.

@kjellr
Copy link
Contributor Author

kjellr commented Aug 23, 2018

@ZebulanStanphill That's a great point. I'll add that to the suggestions above.

@mtias
Copy link
Member

mtias commented Aug 24, 2018

See Query Panel proposal: #2662

@davidknight4242
Copy link

This is actually a general point about all the widgets in Gutenberg....absolutely love them, they work great for me....however, id love to see an optional title available for them as do in other widget areas. Without a title, well its not 100% clear what a visitor is looking at. Optional would mean if someone doesnt want it, well they can leave it blank.

Sorry if this has been mentioned elsewhere, I couldn't find any more information.

@ZebulanStanphill
Copy link
Member

@davidknight4242 You could simply use a Paragraph block to add a title before them, couldn't you?

@davidknight4242
Copy link

Yes a Paragraph block would work, so would a heading. Am actually making a theme and its a not really something I would expect users to remember to do.

I would argue that any widget inside post/page content is an aside to the main content and should have its own aside container and heading, just for better code. At the moment you have a list of dates that to a lot of visitors will not mean anything without a title to explain they are archives. They could be links to old posts, upcoming posts or completely something else.

I get what you mean about the paragraph tag, but requiring one block to explain another seems an unnecessary thing to remember.

@kjellr
Copy link
Contributor Author

kjellr commented Sep 6, 2018

@davidknight4242: There's a bit of prior discussion about widget titles over in this thread: #1011 (comment).

@ZebulanStanphill
Copy link
Member

@davidknight4242 Actually, wrapping widgets in <aside>s would apparently be bad for accessibility and may not actually be semantically correct for individual widgets.

See https://core.trac.wordpress.org/ticket/30556 and some related discussion in #9599.

Personally, I don't see any issue with having to use a Heading or Paragraph block before one of the widget blocks. I already use Heading blocks before the Paragraph blocks in my document to give names to the different sections, so it makes sense to me that I do the same thing for widgets. The best part is that I have complete control over what heading level I use or if I even use a heading at all or just a paragraph, which means I can ensure semantic correctness. If this was all added to the widget blocks, it would clutter their UI with options.

@davidknight4242
Copy link

Thank you Kjellr and ZebulanStanphill, looks like I have some reading to do! Thanks for the help!!

@sarahmonster sarahmonster added the [Block] Archives Affects the Archives Block label Nov 1, 2018
@sarahmonster
Copy link
Member

I'm going to go ahead and close this tracking issue out since it seems that all issues and suggestions have been filed. If we missed anything, please do feel free to open a new issue.

Thanks for your feedback, everyone! 🌟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Archives Affects the Archives Block [Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

No branches or pull requests

5 participants