Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin: Let's get Gutenberg in the plugin repository 🎉 #953

Closed
jasmussen opened this issue May 31, 2017 · 9 comments
Closed

Plugin: Let's get Gutenberg in the plugin repository 🎉 #953

jasmussen opened this issue May 31, 2017 · 9 comments
Assignees
Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Question Questions about the design or development of the editor.
Milestone

Comments

@jasmussen
Copy link
Contributor

It's time we get this baby out into the wider world. Let's look at what's required for us to ship this plugin in the repository.

This would essentially fix #655 through other means.

@jasmussen jasmussen added [Type] Question Questions about the design or development of the editor. Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts labels May 31, 2017
@ntwb
Copy link
Member

ntwb commented May 31, 2017

Creating a new #meta ticket to have it added as a featured plugin regularly sync'd has would be ideal:

https://meta.trac.wordpress.org/browser/sites/trunk/api.wordpress.org/public_html/dotorg/github-sync/feature-plugins.php#L17

@nylen
Copy link
Member

nylen commented May 31, 2017

One thing we need to do first is make sure our vendor scripts are bundled with the plugin and not re-downloaded every day, or on each page load.

@westonruter
Copy link
Member

I don't think the featured plugin sync will work with Gutenberg as-is because it creates plugins from master without doing any build step (unless it is updated to support that). I think instead a Travis CI integration should be done which builds pushes to master and then commits them to plugin SVN (via credentials stored in encrypted environment vars, though these credentials could be leaked by a malicious contributor hacking the .travis.yml file).

@mtias
Copy link
Member

mtias commented May 31, 2017

I was planning on just pushing the build manually on a weekly basis or so to the directory. Not sure if setting up something more complex is worth the time.

@mtias
Copy link
Member

mtias commented Jun 1, 2017

@nylen do you think you can handle the bundling tasks?

@westonruter
Copy link
Member

Can part of this be to also exclude React and ReactDOM from being bundled into the app so that they can be re-used by other JS apps, such as in plugins that define their own blocks, to avoid multiple copies of React needing to be loaded? I believe this was already talked about in regards to JS modules in WP.

@aduth
Copy link
Member

aduth commented Jun 3, 2017

They shouldn't be bundled. They're referenced as externals to their respective globals enqueued server-side.

@nylen
Copy link
Member

nylen commented Jun 12, 2017

We should be ready to do this now. See #1147 for other considerations for each release, such as git tagging.

@jasmussen
Copy link
Contributor Author

Closing this as fixed. HOORAAAY! Great job everyone 🌟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Question Questions about the design or development of the editor.
Projects
None yet
Development

No branches or pull requests

6 participants