Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover image is broken for authors #9955

Closed
notnownikki opened this issue Sep 17, 2018 · 2 comments
Closed

Cover image is broken for authors #9955

notnownikki opened this issue Sep 17, 2018 · 2 comments
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended

Comments

@notnownikki
Copy link
Member

Describe the bug

kses does not allow inline styles that have ( in them. The current implementation of the cover images has background-image: url(...) which gets stripped out by kses when a non-admin users saves it. When the post is reloaded, the block is broken. The published post does not contain the image.

#9954 adds tests for kses behaviour which showed this.

To Reproduce

  1. Log in as an author.
  2. Add a cover image.
  3. Publish the post.
  4. View the published post. The image is missing.

Expected behavior
The image should appear.

@notnownikki notnownikki added [Type] Bug An existing feature does not function as intended [Feature] Blocks Overall functionality of blocks labels Sep 17, 2018
@notnownikki
Copy link
Member Author

cc @aduth @pento

@aduth
Copy link
Member

aduth commented Sep 17, 2018

This is definitely something which needs to be resolved, but is tracked already at #2539 (although previously confusingly titled as targeting multisite, but it's the same issue).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants