Improve placeholder text phrasing for media blocks #16135
Conversation
kjellr
added
[Feature] Blocks
kjellr
requested review from
ajitbohra,
ellatrix,
gziolo,
jorgefilipecosta,
notnownikki,
Soean,
talldan and
youknowriad
as code owners
| @@ -175,14 +175,14 @@ export class MediaPlaceholder extends Component { | |||
| const isVideo = isOneType && 'video' === allowedTypes[ 0 ]; | |||
|
|
|||
| if ( instructions === undefined && mediaUpload ) { | |||
| instructions = __( 'Drag a media file, upload a new one or select a file from your library.' ); | |||
| instructions = __( 'Upload a media file or pick one from your media library.' ); | |||
There was a problem hiding this comment.
This one doesn't contain the "or add one with a URL" part, because the media & text block doesn't include that option.
|
This is a good improvement and feels more consistent, great work! I was debating on whether an oxford comma or rewording could be used on Cover, but ultimately feels like the direction you took makes the most sense. |
kjellr
changed the title
There was a problem hiding this comment.
This looks to be a good improvement. Ship it!
It might be worth considering if we need this text at all. Does it add any additional context or help users understand how to add media? It seems to just be wordily replicating messaging that already exists on the buttons, without adding any additional context.
|
Thanks folks.
I agree. 😄 This is a good small, iterative improvement on what we have, and I think we can keep going in further PRs. |
kjellr
removed
the
Needs Copy Review
…rnmobile/open-video-by-browser-for-android * 'master' of https://github.com/WordPress/gutenberg: (34 commits) [RNMobile] Native mobile release v1.7.0 (#16156) Scripts: Document and simplify changing file entry and output of build scripts (#15982) Block library: Refactor Heading block to use class names for text align (#16035) Make calendar block resilient against editor module not being present (#16161) Bump plugin version to 5.9.1 Editor: Fix the issue where statics for deprecated components were not hoisted (#16152) Build Tooling: Use "full" `npm install` for Build Artifacts Travis task (#16166) Scripts: Fix naming conventions for function containing CLI keyword (#16091) Add native support for Inserter (Ported from gutenberg-mobile) (#16114) docs(components/higher-order/with-spoken-messages): fix issue in example code (#16144) docs(components/with-focus-return): fix typo in README.md (#16143) docs(block-editor/components/inspector-controls): fix image path in README.md (#16145) Add mention of on Figma to CONTRIBUTING.md (#16140) Bring greater consistency to placeholder text for media blocks. (#16135) Add descriptive text and a link to embed documentation in embed blocks (#16101) Update toolbar-text.png (#16102) Updating changelogs for the Gutenberg 5.9 packages release chore(release): publish [RNMobile] Fix pasting text on Post Title (#16116) Bump plugin version to 5.9.0 ... # Conflicts: # packages/block-library/src/video/video-player.android.js
Closes #8409
This PR edits the placeholder text for the following blocks, cleaning up the sentence structure and phrasing.
It uses the recommendations in the original ticket, but with some minor adjustments (from a DM with @michelleweber):
For when there's a URL option:
For when there's no URL option:
Before:
After: