Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Block: Button' not using latest button structure #63

Open
lewisself64 opened this issue Dec 16, 2020 · 2 comments
Open

'Block: Button' not using latest button structure #63

lewisself64 opened this issue Dec 16, 2020 · 2 comments

Comments

@lewisself64
Copy link

The buttons blocks on the "Block: Button" post is out dated and should be wrapped inside of the .wp-buttons wrapper. If theme developers use this class, the theme may appear to have bugs.

@joyously
Copy link
Contributor

Are you saying that someone who created a Button block when this markup was produced, would have to edit their post in order for it to get the current markup, so that the theme could show it correctly?
Shouldn't the theme style the HTML so that all the variations(legacy, intermediate, and current) look correct?

@lewisself64
Copy link
Author

Yes that's what I meant. I have modified my theme to style it without this class and I did wonder if it was purposely like this to try to make sure the button styling is backwards compatible but if that is the case it wasn't clear and I thought I had a bug. Would it not be a good idea to create a new section with the more current buttons and title it to make it obvious to the developer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants