Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

twentytwentyfive is shipping without comments on pages by default, unit test data makes testing confusing #90

Open
HeatherActon opened this issue Oct 22, 2024 · 1 comment
Open

twentytwentyfive is shipping without comments on pages by default, unit test data makes testing confusing #90

HeatherActon opened this issue Oct 22, 2024 · 1 comment

Comments

@HeatherActon
Copy link

Related to: WordPress/twentytwentyfive#490

When testing twentytwentyfive theme with the current unit test data, "Page with comments" content says that comments should be displayed. But in the issue linked above, it was decided that twentytwentyfive would not have comments displayed by default.

Suggest that we update the content to reflect the differences between core themes at least?
@HeatherActon HeatherActon mentioned this issue Oct 22, 2024
Closed
@joyously
Copy link
Contributor

The test content shouldn't change just because a core theme doesn't do it correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HeatherActon @joyously