Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to add fonts for https://asia.wordcamp.org/2024/ #1189

Closed
candy02058912 opened this issue Jan 2, 2024 · 3 comments · Fixed by #1226
Closed

Request to add fonts for https://asia.wordcamp.org/2024/ #1189

candy02058912 opened this issue Jan 2, 2024 · 3 comments · Fixed by #1226

Comments

@candy02058912
Copy link
Collaborator

Related Issue: #1075

As @StevenDufresne suggested:

For the time being, as @dd32 has suggested, we'll manually add fonts until WordPress/gutenberg#55063.
If you want to use a Google Font, open an issue with the fonts you want to be added.

Would like to make a request for the following fonts to be added for https://asia.wordcamp.org/2024/

@import url('https://fonts.googleapis.com/css2?family=Roboto&family=Roboto+Slab:wght@400;500;600;700;800&family=Sansita&display=swap');

Appreciate the help 🙏

@StevenDufresne StevenDufresne self-assigned this Jan 3, 2024
@StevenDufresne
Copy link
Contributor

Update: I've tried manually adding them to the fonts folder, but it does appear like some built-it post types are being created:

https://github.com/WordPress/gutenberg/blob/45dc4b1a0e59abe6870078d3538a4e81a58e8191/lib/experimental/fonts/font-library/class-wp-font-family.php#L483

I haven't figured out how to create those yet.

@renintw
Copy link
Contributor

renintw commented Jan 30, 2024

Just noted that the requested fonts have already been added to the site and font variants can now be activated in the fonts manager.
However, due to existing typekit dependencies, they need to be removed first before activation to avoid conflicts that could break the website.
@candy02058912 @miminari

@miminari
Copy link
Member

@renintw Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants