Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to add fonts to https://europe.wordcamp.org/2024/ and https://wceutest24.wordcamp.org/2024/ #1203

Closed
hideandgeek404 opened this issue Jan 16, 2024 · 10 comments · Fixed by #1216
Assignees

Comments

@hideandgeek404
Copy link

Related Issue: #1075

As @StevenDufresne suggested:

For the time being, as @dd32 has suggested, we'll manually add fonts until WordPress/gutenberg#55063.
If you want to use a Google Font, open an issue with the fonts you want to be added.

Would like to make a request for the following fonts to be added for both https://europe.wordcamp.org/2024/ and https://wceutest24.wordcamp.org/2024/

@import url('https://fonts.googleapis.com/css2?family=Krona+One&display=swap');
@import url('https://fonts.googleapis.com/css2?family=Lora&display=swap');

Thank you very much for all your help!

@pkevan
Copy link
Contributor

pkevan commented Jan 16, 2024

@StevenDufresne did you figure out a solution for this?

@StevenDufresne
Copy link
Contributor

StevenDufresne commented Jan 17, 2024

This should be done.

You'll need to activate the variant on each site:

Screenshot
Screenshot 2024-01-17 at 1 36 03 PM

@hideandgeek404
Copy link
Author

hideandgeek404 commented Jan 18, 2024

Hmm, maybe we aren't doing something right but even with those fonts appearing in the Global Styles options, they do not seem to be getting loaded. There are some font's being loaded from Google (such as Inter) but these custom ones are not appearing anywhere and the site falls back to the sans serif default font.

Any ideas what we might be missing?

I looked at the Install fonts section and noticed that that one seemed to have the correct font but the variant was Krona One 400 normal. Could this be the issue?
image

@ryelle
Copy link
Contributor

ryelle commented Jan 18, 2024

It looks like we need to do a little more on the WordCamp site to make this work— I added a draft page to test fonts to the WC Europe site which I've been using to test this, but so far I haven't gotten it working.

@ryelle
Copy link
Contributor

ryelle commented Jan 22, 2024

@hideandgeek404 Okay, Krona One and Lora should be available for WordCamp Europe now. I see them loaded and rendered on the front end in my test page:

Screenshot 2024-01-22 at 11 37 03 AM

@CarlosLongarela
Copy link

CarlosLongarela commented Jan 22, 2024

Thanks @ryelle in our testing website (https://wceutest24.wordcamp.org/2024/) in frontend, don't load the fonts (we force to load with CSS loading the file from Google Fonts):

image

But if it's working on the live website, it's ok.

Thought is, would be possible to load the fonts in woff2 format? (we have the fonts in that format if they are necessary).

Thanks.

@ryelle
Copy link
Contributor

ryelle commented Jan 22, 2024

I only activated them on the main WCEU site, but they are available on the test site too. If you load these, you can remove your google fonts workaround.

Screenshot 2024-01-22 at 6 15 28 PM

Thought is, would be possible to load the fonts in woff2 format? (we have the fonts in that format if they are necessary).

The process we've got right now is a patch until this feature is better supported in core, and it sounds like the core process should support woff2. But yes, I can swap out the files for woff2. I'll let you know when that's done.

@CarlosLongarela
Copy link

Oh, fantastic, I deactivated the two additional fonts, activated these two fonts as Theme fonts, deleted the additional CSS hack, deleted cache and working fine. Thanks.

image

@CarlosLongarela
Copy link

@ryelle sorry to bother you with this again. On the live website, we will change the current theme (2023) to the 2024 theme in a few days to transfer the staging website design. Would be necessary to install these two fonts again?

@ryelle
Copy link
Contributor

ryelle commented Jan 23, 2024

Would be necessary to install these two fonts again?

No, the fonts should be available for any block theme 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants