Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RadioGroup Preview should work based on index. #2937

Open
mannycarrera4 opened this issue Sep 26, 2024 · 0 comments
Open

RadioGroup Preview should work based on index. #2937

mannycarrera4 opened this issue Sep 26, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@mannycarrera4
Copy link
Contributor

🐛 Bug Report

In Radio Main, we map over children and give it a default value : https://github.com/Workday/canvas-kit/blob/master/modules/react/radio/lib/RadioGroup.tsx#L74

In preview if you don't provide a value it doesn't default by using the index of the radio input. Should this work by default? Technically this is a change in the API. In Preview, you have to explicitly define a value in order for the radio to work.

@mannycarrera4 mannycarrera4 added the bug Something isn't working label Sep 26, 2024
@jaclynjessup jaclynjessup moved this to 🆕 New in Canvas Kit Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant