Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mapbox-gl conflicting peer dependency #412

Open
dereekb opened this issue Jan 11, 2024 · 1 comment · May be fixed by #413
Open

mapbox-gl conflicting peer dependency #412

dereekb opened this issue Jan 11, 2024 · 1 comment · May be fixed by #413

Comments

@dereekb
Copy link

dereekb commented Jan 11, 2024

When trying to update to mapbox-gl 3.x or higher npm throws an error. Does ngx-mapbox-gl@10.0.0 support version 3 of mapbox-gl? It seems like there are no breaking changes in the API, just dropping support for some older browsers.

If so, can the peer dependencies be updated to reflect that? I can make a PR.
@dereekb dereekb linked a pull request Jan 11, 2024 that will close this issue
Open
@airbreather airbreather mentioned this issue Jul 5, 2024
Open
@airbreather
Copy link

airbreather commented Jul 5, 2024 •
edited
Loading

It seems like there are no breaking changes in the API, just dropping support for some older browsers.

Maybe not, but per mapbox/mapbox-gl-js#13203, there might as well be now. I posted a workaround on that thread to show how to still use this with newer versions going forward, but these workarounds are piling up.

It feels like it's forking time now.

@MaximBelov MaximBelov mentioned this issue Oct 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: adjust package json compat dereekb/ngx-mapbox-gl
2 participants
@dereekb @airbreather