Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug:<mgl-geojson-source> error when routing away before map has loaded #6

Closed
Tobbyte opened this issue Nov 16, 2017 · 1 comment
Closed

bug:<mgl-geojson-source> error when routing away before map has loaded #6

Tobbyte opened this issue Nov 16, 2017 · 1 comment

Comments

@Tobbyte
Copy link

Tobbyte commented Nov 16, 2017

Reproduce:

  • add a <mgl-geojson-source id="symbols-source"></mgl-geojson-source> to a map (doesn't madder if w or w/o <mgl-feature>.
  • rout away from page with map before map has fully loaded.
  • Error:
Error: Uncaught (in promise): TypeError: Cannot read property 'unsubscribe' of undefined
TypeError: Cannot read property 'unsubscribe' of undefined
    at GeoJSONSourceComponent.ngOnDestroy (geojson-source.component.ts:79)
@Wykks
Copy link
Owner

Wykks commented Nov 17, 2017

Oh wow, I usually doesn't do this kind of mistake :(

Thanks for finding that out

@Wykks Wykks closed this as completed in ac8172e Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Wykks @Tobbyte