fix(per): encoding extensible string types #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your PR! Could you add some test cases for this, to prevent future regressions? |
|
Sure, will do. |
XAMPPRocky
approved these changes
Oct 19, 2023
|
Thank you for your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple of issues with PER-encoding extensible string types, such as
BIT STRING,OCTET STRINGorVisibleString. Before, extensible string types were in some cases encoded with a duplicate extension marker, in some cases with a wrong length determinant.I also refactored the string encoders so that extension bits are always written using the
encode_extensible_bitfunction, and removed some code duplication by havingencode_lengthcall theencode_string_lengthfunction, which is largely identical.