Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an action which reports the changes of the fields by a PR #1259

Open
dachengx opened this issue Sep 6, 2023 · 3 comments
Open

Add an action which reports the changes of the fields by a PR #1259

dachengx opened this issue Sep 6, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@dachengx
Copy link
Collaborator

dachengx commented Sep 6, 2023

To prevent the issue in #1247 convert some cs2_area_fraction_top to nans) from happening again(at least prevent it from happening a lot), we should check the impact of one PR on the fields.

In details, we should check

  1. The change in the number of nans.
  2. The deleted or added fields.

These can be done by writing scripts of actions.

@dachengx dachengx added the enhancement New feature or request label Sep 6, 2023
@dachengx
Copy link
Collaborator Author

Assuming that we have some functions to iterate through the dependency tree and order the plugins by their "genetic relationship", then we can search for the oldest change of lineage, and compare the data produced.

Here is the plan:

  1. search for deleted plugins, and report their names
  2. search for the added plugins and report:
    +. the fraction of nan(0 and -1) of float(int) fields
  3. search for the oldest changed(in lineage, because the __version__ will be tracked by lineage) plugin and report
    +. the fraction of nan(0 and -1) of float(int) fields
    +. the mean absolute change in each field
    +. whether the oldest lineage-changed plugin is really the oldest results-changed plugin by comparing the result of the second oldest layer of plugins
  4. if possible, compare the change codes, hint at which plugin is really changed by programmer

@JYangQi00
Copy link
Contributor

Thanks Dacheng, is there a database somewhere which tracks the lineage hash of the previous version of plugins, so that we can compare it to the lineage hash of the plugins of a PR?

@dachengx
Copy link
Collaborator Author

The lineage must be deduced from the given codes and configs. So no such docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants