Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency of triggering peaks definition #1496

Open
dachengx opened this issue Dec 10, 2024 · 0 comments · May be fixed by #1498
Open

Inconsistency of triggering peaks definition #1496

dachengx opened this issue Dec 10, 2024 · 0 comments · May be fixed by #1498
Assignees
Labels
enhancement New feature or request

Comments

@dachengx
Copy link
Collaborator

In Events, the triggering peaks are used to find the event window:

_is_triggering = self._is_triggering(peaks)
.

But in EventBasics, we did not distinguish the triggering and non-triggering peaks when assigning main S1/2:

split_peaks = strax.split_by_containment(peaks, events)
. I think we should not consider the non-triggering peaks as main S1/2 to make the events building consistent.

@dachengx dachengx self-assigned this Dec 10, 2024
@dachengx dachengx added the enhancement New feature or request label Dec 10, 2024
@dachengx dachengx linked a pull request Dec 16, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant