Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compression handshake is not handled correctly (Version: 1.7.0-b2) #3624

Closed
gregtatcam opened this issue Oct 12, 2020 · 1 comment
Closed
Assignees
Labels

Comments

@gregtatcam
Copy link
Collaborator

gregtatcam commented Oct 12, 2020

Issue Description

If an outbound node has compression enabled and an inbound node does not have compression enabled then the inbound node enabled link compression.

Steps to Reproduce

Run two nodes. Set compression to enabled in one node's configuration and disabled in another node's configuration.
[compression]
0|1

Expected Result

Both nodes should flag the link compression disabled.

Actual Result

If the outbound node has the compression enabled and the inbound node has the compression disabled then the inbound node is forced into setting the compression flag as enabled. The outbound node consequently drops the connection in this case because the outbound node expects the uncompressed data but the inbound node sends compressed data due to incorrectly set flag.

Environment

Ubuntu 20.04 with Boost 1.70
Release 1.7.0-b2

Supporting Files

compressionEnabled_ flag should include additional condition app_.config().COMPRESSION in https://github.com/ripple/rippled/blob/develop/src/ripple/overlay/impl/PeerImp.cpp#L94 the same as in
https://github.com/ripple/rippled/blob/develop/src/ripple/overlay/impl/PeerImp.h#L644

@mDuo13
Copy link
Collaborator

mDuo13 commented Mar 15, 2021

Done in 1.7.0-b9 #3708

@mDuo13 mDuo13 closed this as completed Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants