From 7495c02b32fa7828a12319fdbef74425809f5569 Mon Sep 17 00:00:00 2001 From: Ed Hennis Date: Tue, 3 Oct 2023 14:11:28 -0400 Subject: [PATCH 1/2] Update API CHANGELOG for `XRPFees` changes * Adds a new section for release 1.10. * Also marks `jss::fee_ref` as deprecated in case `XRPFees` is ever retired. * Also fixes a copy-paste error in one of the unit tests related to that fix. --- API-CHANGELOG.md | 11 +++++++++++ src/ripple/protocol/jss.h | 2 +- src/test/app/TxQ_test.cpp | 6 +++--- 3 files changed, 15 insertions(+), 4 deletions(-) diff --git a/API-CHANGELOG.md b/API-CHANGELOG.md index 989a1f8056a..c0113e073b6 100644 --- a/API-CHANGELOG.md +++ b/API-CHANGELOG.md @@ -94,6 +94,17 @@ Additions are intended to be non-breaking (because they are purely additive). - Added `NFTokenPages` to the `account_objects` RPC. (https://github.com/XRPLF/rippled/pull/4352) - Fixed: `marker` returned from the `account_lines` command would not work on subsequent commands. (https://github.com/XRPLF/rippled/pull/4361) +## XRP Ledger version 1.10.0 + +[Version 1.10.0](https://github.com/XRPLF/rippled/releases/tag/1.10.0) +was released on Mar 14, 2023. + +### Breaking changes in 1.10 + +- If the `XRPFees` feature is enabled, the `fee_ref` field will be + removed from the Ledger subscription stream, because it will no longer + have any meaning. + # In development Changes below this point are in development. diff --git a/src/ripple/protocol/jss.h b/src/ripple/protocol/jss.h index 9a3e315dd8e..e31a1cb3bf8 100644 --- a/src/ripple/protocol/jss.h +++ b/src/ripple/protocol/jss.h @@ -315,7 +315,7 @@ JSS(fee_base); // out: NetworkOPs JSS(fee_div_max); // in: TransactionSign JSS(fee_level); // out: AccountInfo JSS(fee_mult_max); // in: TransactionSign -JSS(fee_ref); // out: NetworkOPs +JSS(fee_ref); // out: NetworkOPs, DEPRECATED JSS(fetch_pack); // out: NetworkOPs JSS(first); // out: rpc/Version JSS(firstSequence); // out: NodeToShardStatus diff --git a/src/test/app/TxQ_test.cpp b/src/test/app/TxQ_test.cpp index 4bc0040f867..ac6bf56f06c 100644 --- a/src/test/app/TxQ_test.cpp +++ b/src/test/app/TxQ_test.cpp @@ -4843,13 +4843,13 @@ class TxQ1_test : public beast::unit_test::suite drops[jss::base_fee] == "0"); BEAST_EXPECT( drops.isMember(jss::median_fee) && - drops[jss::base_fee] == "0"); + drops[jss::median_fee] == "0"); BEAST_EXPECT( drops.isMember(jss::minimum_fee) && - drops[jss::base_fee] == "0"); + drops[jss::minimum_fee] == "0"); BEAST_EXPECT( drops.isMember(jss::open_ledger_fee) && - drops[jss::base_fee] == "0"); + drops[jss::open_ledger_fee] == "0"); } } From 012a9cc554f64fb2d9619d82abda785464c6636c Mon Sep 17 00:00:00 2001 From: Ed Hennis Date: Tue, 3 Oct 2023 17:29:57 -0400 Subject: [PATCH 2/2] Take @intelliot's suggestion to add link Co-authored-by: Elliot Lee --- API-CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/API-CHANGELOG.md b/API-CHANGELOG.md index c0113e073b6..704b3c01524 100644 --- a/API-CHANGELOG.md +++ b/API-CHANGELOG.md @@ -102,7 +102,7 @@ was released on Mar 14, 2023. ### Breaking changes in 1.10 - If the `XRPFees` feature is enabled, the `fee_ref` field will be - removed from the Ledger subscription stream, because it will no longer + removed from the [ledger subscription stream](https://xrpl.org/subscribe.html#ledger-stream), because it will no longer have any meaning. # In development