Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab selection is not keeping when switching languages when {% tab label=“”} is translated. #2895

Open
tequdev opened this issue Dec 7, 2024 · 1 comment

Comments

@tequdev
Copy link
Contributor

tequdev commented Dec 7, 2024

https://xrpl.org/docs/references/protocol/ledger-data/ledger-entry-types/directorynode

As an example, if you change the language on the DirectoryNode page, the tabs in the Example DirectryNode JSON section will be unselected.

スクリーンショット 2024-12-07 14 50 07

Since label, which is the display content, is the key for tabs, it should be possible to specify key in addition label.

{% tabs %}
{% tab label=“some text”}
{% /tab %}
{% /tabs %}
@mDuo13
Copy link
Collaborator

mDuo13 commented Dec 18, 2024

To clarify, what you're saying is that, if you're viewing the English version of the DirectoryNode page for example, and you have selected the second tab ("Owner directory" in English), and then you switch to Japanese, it resets the tab to showing the first tab (オファーディレクトリ)?

I see that as expected behavior since changing languages is basically reloading the page. It looks like Redocly's tabs definition does not support any additional keys besides label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants