Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate comparison between pos and index in NSTextStorage+VimOperation.m #1005

Open
yixiang opened this issue Oct 5, 2016 · 1 comment

Comments

@yixiang
Copy link
Contributor

yixiang commented Oct 5, 2016

In [NSTextStorage xvim_firstOfLine], there is a comparison between pos and index (pos == index).

pos is a position in terms of characters but index is line the line number. It definitely feels wrong to compare them, but I was not able to figure out what the expected behavior is with my time constraints. So I'm going to leave that to those who are more familiar with the code.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@tidbeck
Copy link
Contributor

tidbeck commented Jan 8, 2017

Isn't index the position in the text to start searching from and pos the position for the start of the same line?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants