Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File version lowered to 1.0.0 #93

Closed
bdachev opened this issue Oct 22, 2021 · 4 comments · Fixed by #94
Closed

File version lowered to 1.0.0 #93

bdachev opened this issue Oct 22, 2021 · 4 comments · Fixed by #94

Comments

@bdachev
Copy link

bdachev commented Oct 22, 2021

Hi Guys, between 2.0.0 and 2.0.1 release the file version of main assembly lowered from 2.0.0 to 1.0.0.
That creates problem when installing an update using MSI package - older assebly got removed but the new one is not installed.
Any chance to fix the file version of the DLL?

@thomaslevesque
Copy link
Member

Hi @bdachev,
Thanks for reporting this. Not sure how it happened... The package & assembly versions are controlled by minver, and the only change I made between 2.0.0 and 2.0.1 has nothing to do with the assembly version. I'll look into it.

@thomaslevesque
Copy link
Member

I think something changed in the SDK between when the 2.0.0 and 2.0.1 versions were built, which must have broken minver. And minver must have been fixed, because when I update to minver 2.5.0, it generates the correct assembly version again. I'll publish a new package ASAP.

@thomaslevesque
Copy link
Member

I just published version 2.0.2 to NuGet (should be visible in a few minutes after the package is validated and indexed). The assembly now has the correct version.

@bdachev
Copy link
Author

bdachev commented Oct 23, 2021

Hello Thomas, and thank you very much for your prompt responce and reaction! I tested new nuget package and it is all good now! Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants