Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work in VS2019 16.1.2 #186

Closed
rezamohamed opened this issue Jun 11, 2019 · 5 comments
Closed

Does not work in VS2019 16.1.2 #186

rezamohamed opened this issue Jun 11, 2019 · 5 comments
Assignees
Milestone

Comments

@rezamohamed
Copy link

With the most recent upgrade to VS2019 Community 16.1.2 the XAML Styler has stopped working completely.

@NicoVermeir
Copy link
Contributor

seems to work fine for me. can you give some more information? are you getting error messages? what project type are you using?

@JohnnyWestlake
Copy link

JohnnyWestlake commented Jun 13, 2019

I will say that although it does format for me, it's completely ignoring my Settings.XamlStyler file that's further down the folder structure (with search to Root set to true in settings), whereas it did work before the update.

Edit: Actually, it's jut ignoring all settings entirely and only formatting with the defaults for me.

@rezamohamed
Copy link
Author

rezamohamed commented Jun 16, 2019

@NicoVermeir the xaml styler does nothing. I have tried the hot key, I have set style on save etc. But the extensions itself just does nothing. It used to work fine on a couple of builds prior of VS19, but with this build it has just stopped working. I have uninstalled the extension, and reinstalled as well. No difference.

image

UPDATE:
I noticed that when I press Ctrl+k+2 ....only the formatting of the first few attributes (eg xmlns, x:class, ios:, mc) gets formatted. I toggled the option to keep attribute on the first line, and then pressed the ctrl+k+2 buttons, and that is where I noticed this. Nothing else in the example file below gets formatted.

image

@grochocki
Copy link
Contributor

@rezamohamed I addressed a couple verified compatibility issues in #206. I am not 100% sure this will address this issue, but 16.1.2 would definitely be a version I would expect to experience some of the issues that PR addresses. Any chance you can give the build out of master a try on your install and see if that resolves your problem?

@grochocki grochocki self-assigned this Sep 23, 2019
@grochocki grochocki added this to the 3.3 milestone Dec 31, 2019
@grochocki
Copy link
Contributor

Should be addressed in 3.1912.9, available now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants