Adjust XML Escaping to allow for incomplete xmlns inside a comment #462
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #426 (issue)
As per the issue, an incomplete xmlns definition in a comment could break the XML parsing as it would result in an invalid XML document being produced as a result of the escaping.
This change modifies the XML escaping code to allow for such comments to not break the parsing process.
Additionally, this PR adds tests to verify that the XML escaping (& unescaping) code does not cause any issues. This part of the code previously had no test coverage. These tests use all the sample files currently included in the test project for other test cases. I, therefore, assume this to be a comprehensive collection of file scenarios. (A brief look at the files shows they cover a lot!)
Admittedly, the reported issue is a remote edge case, and so it's probably not a high-priority fix. However, as this PR increases test coverage hopefully makes it a beneficial update.
Checklist: