From 6ebf8251f504a850431467896ccb22c5de278f91 Mon Sep 17 00:00:00 2001 From: Francis Gonzales Date: Mon, 18 Jul 2016 11:47:52 -0500 Subject: [PATCH 1/2] Update Code128.php Avoiding warning in the last character https://github.com/zendframework/zend-barcode/issues/28 --- src/Barcode/Code128.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/Barcode/Code128.php b/src/Barcode/Code128.php index 245960073..d17e7d7ce 100644 --- a/src/Barcode/Code128.php +++ b/src/Barcode/Code128.php @@ -180,7 +180,10 @@ public function hasValidCharacters($value) break; } - $value = $strWrapper->substr($value, 1, null); + if (!empty($value) && $value != '') { + $value = $strWrapper->substr($value, 1, null); + } + $read = $set; } From 5551b3d698b1eae7502936e406cc280019c2052f Mon Sep 17 00:00:00 2001 From: Francis Gonzales Date: Mon, 18 Jul 2016 11:54:40 -0500 Subject: [PATCH 2/2] Update Code128.php --- src/Barcode/Code128.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Barcode/Code128.php b/src/Barcode/Code128.php index d17e7d7ce..da4172f75 100644 --- a/src/Barcode/Code128.php +++ b/src/Barcode/Code128.php @@ -180,7 +180,7 @@ public function hasValidCharacters($value) break; } - if (!empty($value) && $value != '') { + if (!empty($value) && strlen($value) > 1) { $value = $strWrapper->substr($value, 1, null); }