Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoice Types do not seem accurate. #426

Open
SerKnight opened this issue Jun 15, 2021 · 1 comment
Open

Invoice Types do not seem accurate. #426

SerKnight opened this issue Jun 15, 2021 · 1 comment

Comments

@SerKnight
Copy link
Contributor

For this specific S/O question, our spec says there can be 8 enums, but old docs just had the two.. (which looks correct)
I tested trying to create with a few of those 6/8, got:

"Message": "Invoice not of valid type for creation"

Queried all demo company Invoice types, getting only:

"Type": "ACCREC",
"Type": "ACCPAY",

https://stackoverflow.com/questions/67986653/xero-invoice-types

Expected Behavior

  • Expect the OAS to only have the Invoice types declared that are possible and expected
  • Expect the core Xero docs (built from this spec) to accurately show descriptions for each invoice type.

Current Behavior

  • types have no descriptions
  • types don't seem accurate for Invoices

Possible Solution

Lots of talk in the OAS work about this. Need to investigate.

json-schema-org/json-schema-vocabularies#47

  • Attaching Enum descriptions all throughout the spec.
@SerKnight
Copy link
Contributor Author

SerKnight commented Jun 15, 2021

Another example is that the descriptions of the UK payroll enums were never represented in the spec.

Once we surface descriptions clearly in the new docs, this solve should be as simply as porting to the OAS the legacy desc's.

Screen Shot 2021-06-15 at 11 56 21 AM
Screen Shot 2021-06-15 at 11 56 30 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant