Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When it changes from php >= 5.6 to >= 7.2 #69

Closed
mmoradeveloper opened this issue Feb 21, 2020 · 3 comments
Closed

When it changes from php >= 5.6 to >= 7.2 #69

mmoradeveloper opened this issue Feb 21, 2020 · 3 comments

Comments

@mmoradeveloper
Copy link

mmoradeveloper commented Feb 21, 2020

I had an issue that has been resolved in future pushes but now the project won't allow me to update to the latest project.

what changes between version ^1.1 and ^1.2 to make that decision?
what can I do to make it work not with php 7?

version 1.1.1 php >= 5.6

Error:
FatalErrorException: Parse: syntax error, unexpected 'function' (T_FUNCTION), expecting identifier (T_STRING) in .../vendor/xeroapi/xero-php-oauth2/lib/IdentityObjectSerializer.php line 50

Thanks

@SidneyAllen
Copy link
Contributor

@mmoradeveloper

We've set PHP 7.2.1 as that's the version we are testing against.
#49

You could try to install and ignore the PHP requirement per this stackoverflow answer.
"run composer with the --ignore-platform-reqs argument"

https://magento.stackexchange.com/questions/207318/php-requirement-incompatible-with-your-php-version-composer-module-installatio

We are open to loosening the PHP version requirement, but would like to hear from the community that they've tested the SDK on version 5.x and shared the outcome with us.

@wobinb
Copy link
Contributor

wobinb commented May 1, 2020

The latest update, should have resolved this here: #110

Please let us know if not.

@wobinb wobinb closed this as completed May 1, 2020
@SidneyAllen
Copy link
Contributor

@mmoradeveloper - I've done some testing with PHP 5.6. Please try xero-php-oauth2 version 1.6.2 which has been tested and now requires PHP 5.6+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants