Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arabic Subtitles Cause Script to Fail/Incorrectly Handled #39

Closed
leptoid opened this issue Jan 26, 2018 · 4 comments
Closed

Arabic Subtitles Cause Script to Fail/Incorrectly Handled #39

leptoid opened this issue Jan 26, 2018 · 4 comments
Labels

Comments

@leptoid
Copy link
Contributor

leptoid commented Jan 26, 2018

When an episode of a show with subtitle arME.ass is downloaded, subs and video mux. Script errors and continues on with the next function of the script which is deleting all temp files (note - nothing is moved to output). Not all shows have these which is why error seems intermittent between shows.
Here are some that do:

Boruto
The Ancient Magus
Darling In The Franxx

Delete the arME.ass subtitle file before scripts attempt to multiplex subtitles with video allows everything to mux correctly, due to the incorrectly handled subs no longer being a factor.

@Xonshiz
Copy link
Owner

Xonshiz commented Jan 27, 2018

Thanks for creating the new issue. Noted.

@Xonshiz Xonshiz added the bug label Jan 27, 2018
@Xonshiz
Copy link
Owner

Xonshiz commented Jan 27, 2018

Shouldn't cause more problems now. Updated windows binary released, check on your end please.

@leptoid
Copy link
Contributor Author

leptoid commented Jan 28, 2018

Yep, it is good now.

@Xonshiz
Copy link
Owner

Xonshiz commented Jan 28, 2018

Thanks for the confirmation :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants