Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X11 bindings refactoring #1034

Open
totaam opened this issue Nov 16, 2015 · 1 comment
Open

X11 bindings refactoring #1034

totaam opened this issue Nov 16, 2015 · 1 comment
Labels
enhancement New feature or request X11
Milestone

Comments

@totaam
Copy link
Collaborator

totaam commented Nov 16, 2015

Follow up from #907, related to #640, #41, #990, #846, #881, #911

Issues:

  • group-leader code calls gtk
  • prop_get is called from an XSync context we manage, should never call into GTK - it doesn't, but we should make certain it never will
  • split prop_get into X11_prop_get and inject X11 dependency?
  • can-focus is not used
  • call_setup() is inconsistent
  • WM_STATE still a bit of a mess..
  • iconic: boolean is not good enough? (need to map Withdrawn.. old clients can't do it)
  • use managed connect for notify:: in callers?
  • simplify X11 signals: rename them X11zzz, ie: do_X11ClientMessage(..)
  • XChangeWindowAttributes can be used to change OR!?
  • x11_get_server_time -> replace with native X11 call?
  • get_default_window_icon?
  • _NET_WM_ACTION_CLOSE
  • client_reparented should be original parent (cleaner?) - not safe
  • WM_CLIENT_MACHINE: use XGetWMClientMachine
  • add_event_receiver / remove_event_receiver: use WeakHashMap to workaround gtk3 lack of set_data, would need route_event anyway - meh
@totaam
Copy link
Collaborator Author

totaam commented May 22, 2023

A lot refactoring was done as part of #1995

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request X11
Projects
None yet
Development

No branches or pull requests

1 participant