Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more sharing options client side #1368

Closed
totaam opened this issue Nov 19, 2016 · 13 comments
Closed

more sharing options client side #1368

totaam opened this issue Nov 19, 2016 · 13 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Nov 19, 2016

Issue migrated from trac ticket # 1368

component: client | priority: minor | resolution: fixed

2016-11-19 10:25:30: antoine created the issue


Follow up from #41.

It would be nice if the clients could specify more than sharing on or off.
Maybe add the ability to refuse to let other users steal the session? ("keep"?)
The other user would have to issue an "xpra disconnect" first before being able to connect?
We still need a way to take over stuck sessions, otherwise the only option would be to "xpra stop" it which isn't very user friendly.

@totaam
Copy link
Collaborator Author

totaam commented Nov 22, 2016

2016-11-22 06:17:37: antoine changed status from new to assigned

@totaam
Copy link
Collaborator Author

totaam commented Nov 22, 2016

2016-11-22 06:17:37: antoine commented


See also #1369: the sharing option could be used to define the offset for each client.
Taking this even further: we could even have the option to force the client to map to the same full-screen size (scaling client size display to match whatever is on the server) - somewhat related to #972.

@totaam
Copy link
Collaborator Author

totaam commented Jul 20, 2017

2017-07-20 08:10:07: antoine commented


too late to make changes, re-scheduling

@totaam
Copy link
Collaborator Author

totaam commented Aug 28, 2017

2017-08-28 05:28:09: antoine commented


Sharing code has been refactored into a utility method handle_sharing() in r16712 so RFB (#1620) can make use of it.

@totaam
Copy link
Collaborator Author

totaam commented Oct 28, 2017

2017-10-28 18:17:51: antoine changed status from assigned to new

@totaam
Copy link
Collaborator Author

totaam commented Oct 28, 2017

2017-10-28 18:17:51: antoine changed owner from antoine to maxmylyn

@totaam
Copy link
Collaborator Author

totaam commented Oct 28, 2017

2017-10-28 18:17:51: antoine commented


Done in r17268 with the "lock" option, which can be modified at runtime from the system tray.

The semantics of "sharing" has changed somewhat, this is how the server handles the value:

  • sharing=no disables all sharing
  • sharing=yes now enables sharing for all clients, ignoring what the clients request
  • sharing=auto lets the clients decide - this is the default value
    "auto" defaults to "no" on the client.

The same logic applies to the new "lock" switch. A locked session cannot be stolen by another user, though it may still be shared if that is enabled.

@maxmylyn: mostly a FYI. Feel free to close.
I may follow up in #1369 and #972.

@totaam
Copy link
Collaborator Author

totaam commented Nov 1, 2017

2017-11-01 06:52:03: antoine commented


r17274 allows the "lock" and "sharing" attributes to be changed at runtime, either via dbus or via "xpra control".

ie:

xpra control :1 set-lock auto
xpra control :1 set-sharing off

Unfortunately, this can have undesirable side effects since we don't yet communicate the changes to the client: #1676

@totaam
Copy link
Collaborator Author

totaam commented Nov 1, 2017

2017-11-01 18:56:24: maxmylyn changed status from new to closed

@totaam
Copy link
Collaborator Author

totaam commented Nov 1, 2017

2017-11-01 18:56:24: maxmylyn set resolution to fixed

@totaam
Copy link
Collaborator Author

totaam commented Nov 1, 2017

2017-11-01 18:56:24: maxmylyn commented


Very nice - noted and closing.

@totaam totaam closed this as completed Nov 1, 2017
@totaam
Copy link
Collaborator Author

totaam commented Nov 15, 2017

2017-11-15 10:59:50: antoine commented


We could improve the UI for this a bit: #1690

@totaam
Copy link
Collaborator Author

totaam commented Oct 17, 2019

2019-10-17 16:03:28: antoine commented


r17804 updates the system tray if the "sharing" or "lock" options have been changed on the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant