Modal Window in Xpra

[totaam]

Issue migrated from trac ticket # 1895

component: client | priority: major | resolution: fixed

2018-07-03 15:42:57: ibuprofene created the issue

---

It is not possible for now to use modal window on xpra. Is it possible to add on option to allow it ?

[totaam]

2018-07-04 09:11:41: antoine changed owner from antoine to ibuprofene

[totaam]

2018-07-04 09:11:41: antoine changed component from android to client

[totaam]

2018-07-04 09:11:41: antoine commented

---

Done in r19834.

If you start the client with XPRA_MODAL_WINDOWS=1 then the client will set the modal flag on windows.

@ibuprofene: does that work for you?
some beta packages posted here: [https://xpra.org/beta]
(let me know if your distro doesn't have builds recent enough)

We could turn this option into a tray menu toggle. (but I'm not sure if toggling the modal flag would affect existing windows properly or not)

[totaam]

2018-07-06 14:57:31: ibuprofene commented

---

Hello,
It doesn't work with my current version: xpra v2.3.1-19531
I will try with a beta as soon as possible.
I use CENTOS

[totaam]

2018-07-06 17:20:07: antoine commented

---

It doesn't work with my current version: xpra v2.3.1-19531
This flag is only in the beta builds at present.
If this works for you, I will then apply it to the stable 2.3.x branch.

I use CENTOS
Which release? 7.5?

[totaam]

2018-07-07 11:28:05: antoine commented

---

In any case, there are now beta packages for all centos7 releases.

r19869 enabled this by default (since I haven't encountered any problems with it so far - can revert later), adds a command line option (modal-windows=yes|no) and a toggle in the system tray.

We could also make the tray toggle apply to existing windows, rather than only apply to new windows. (using a setter method on the client to iterate over the windows and set the value from the metadata cache)

[totaam]

2018-07-10 13:40:14: antoine changed status from new to closed

[totaam]

2018-07-10 13:40:14: antoine set resolution to fixed

[totaam]

2018-07-10 13:40:14: antoine commented

---

r19906 re-sets the flag on all the windows whenever the value in the system tray menu is toggled.

That will do.

[totaam]

2018-07-10 17:51:09: ibuprofene commented

---

Ok so I tried the new version of xpra but it didn't work properly, when I start the client it says "VM blacklisted" and it doesn't work.
Notice that it could be another problem, I will try on an other machine and I'll tell you.

[totaam]

2018-07-10 17:55:15: antoine commented

---

Ok so I tried the new version of xpra but it didn't work properly,
What exact version?
when I start the client it says "VM blacklisted"..
What is the exact message? Is this the opengl message? (this one has not changed at all for a while)
and it doesn't work
What is "it"?
The client? The connection? The modal windows?

[totaam]

2018-07-10 20:41:23: ibuprofene commented

---

Hello, thank you for your reactivity:
xpra v2.4-r19869
Yes it was the openGL message, I don't have this issue anymore.
The "it" is the whole thing, when I start the client both client and servers crash

[totaam]

2018-07-10 20:58:57: antoine commented

---

The "it" is the whole thing, when I start the client both client and servers crash
That's very very unlikely.
What is the client output and server log?

[totaam]

2018-07-10 21:27:26: ibuprofene commented

---

Well I'm not working on this machine anymore so I cannot tell you exactly what was the output, I will have access tomorrow when I'll go back to my work, I'll send you evrything then.

I have just created a new VM with centos 7.5 to test your patch, so I've installed xpra and xpra --version returns: xpra v2.4-r19869
So I think it is the good one
Then I use the following comand line:

xpra start :99 --daemon=no --start-via-proxy=no --webcam=no --start-new-commands=yes \
   --encodings=rgb,png,h264,vp8,vp9 --quality=100 --min-quality=95 --pixel-depth=24 \
   --mdns=no --html=yes --bind-tcp=0.0.0.0:1203 --pulseaudio=no --resize-display=no \
   --file-transfer=yes --printing=no --speaker=disabled --microphone=disabled \
   --exit-with-children --modal-windows=yes --start-child="myapp"

on server and I use the browser to connect and I don't have my modal window, but I think I miss something, I don't understand what you mean by " a toggle in the system tray", is there something else to do ?

Thank you again

[totaam]

2018-07-11 03:40:39: antoine commented

---

and I use the browser to connect
You must be joking. You are using the HTML5 client and you only mention this in comment:10. All the work I did was for the regular python client.

Please file a separate ticket for that, and make it clear that this is for the HTML5 client as per ReportingBugs.

[totaam]

2018-07-11 08:33:02: ibuprofene commented

---

No you did well, so far I was using the python client but yesterday as I hadn't xpra on my machine I tried with the browser, I thought It was the same, sorry, I apologize, but anyway even with the python client I don't have my modal window :(

[totaam]

2018-07-11 14:16:59: ibuprofene commented

---

Ok so I came back on my computer and I realized that I had edited some env variables and there was aparently a conflit between my X server and Xpra so I changed it and now it's fine, and wow the modal works ! Thank you very much !
Excuse me if I wasn't clear sometimes, I'll try to be more precise in the future because I have an other bug to report.

[totaam]

2019-04-13 07:11:27: antoine commented

---

Caused a regression: #2270, so this is now disabled again by default in 2.5.x - a different fix has been applied for 3.0. (see #2270#comment:4 for details)

[totaam]

2020-04-03 13:25:57: antoine commented

---

Disabled by default again: #2706