Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Placeholder API support #37

Open
1 task done
Bizzonium opened this issue Jun 9, 2022 · 7 comments · May be fixed by #241
Open
1 task done

[Enhancement] Placeholder API support #37

Bizzonium opened this issue Jun 9, 2022 · 7 comments · May be fixed by #241
Labels
enhancement New feature or request

Comments

@Bizzonium
Copy link

Checks

Description

https://placeholders.pb4.eu/

@Bizzonium Bizzonium added the enhancement New feature or request label Jun 9, 2022
@Xujiayao
Copy link
Owner

Xujiayao commented Jun 9, 2022

I will look into this feature after the 1.19 release.

@Xujiayao
Copy link
Owner

Not necessary, complicated, all code needs to be rewritten.

@Xujiayao Xujiayao closed this as not planned Won't fix, can't repro, duplicate, stale Jun 12, 2022
@Xujiayao Xujiayao added the wontfix [NP] This will not be worked on label Jun 12, 2022
@Xujiayao Xujiayao changed the title [Enhancement] Placeholder API support + mods placeholders [Enhancement] Placeholder API support Jun 12, 2022
@unilock
Copy link

unilock commented Dec 24, 2023

I think it would be quite a lot more convenient for the user to be able to use TextPlaceholderAPI instead of raw JSON in the config, for the few settings that enforce it. It would also be convenient to have access to the other placeholders exposed by said API.

Would you at least be willing to consider a PR that implements / makes use of TextPlaceholderAPI, if one were made?

@Xujiayao
Copy link
Owner

I think it would be quite a lot more convenient for the user to be able to use TextPlaceholderAPI instead of raw JSON in the config, for the few settings that enforce it. It would also be convenient to have access to the other placeholders exposed by said API.

Would you at least be willing to consider a PR that implements / makes use of TextPlaceholderAPI, if one were made?

Yes, I have seen many issues mentioning this, as MCDC is incompatible with some mods due to its use of its own method for parsing messages. It would certainly be best if there were any PRs to support it, as long as all existing MCDC functions are retained.

I am not very available at the moment, so PRs and non-urgent issues may not be reviewed promptly.

@Xujiayao Xujiayao reopened this Jan 3, 2024
@Xujiayao Xujiayao added good first issue Good for newcomers and removed wontfix [NP] This will not be worked on labels Jan 3, 2024
@Xujiayao Xujiayao added good first issue Good for newcomers and removed good first issue Good for newcomers labels Jan 17, 2024
@Xujiayao Xujiayao pinned this issue Jan 17, 2024
@Xujiayao
Copy link
Owner

This is confirmed to be a feature that MCDC v3 will support.

@unilock
Copy link

unilock commented Jan 17, 2024

That's great! I did try to implement it myself a few weeks ago, but determined I wasn't familiar enough with the codebase to implement TextPlaceholderAPI alongside the JSON-based config that was already present.

Regardless, here's my WIP fork, if you're interested: unilock@1128506

@Xujiayao
Copy link
Owner

OK, thanks for providing it. I'll look into it when I start developing v3. You may submit a Draft PR if you prefer to be given credit for contribution.

Apologize for letting you see my shit mountain code about formatting messages lmao. That's why I don't want to touch it (as long as it works).

@Xujiayao Xujiayao linked a pull request Jul 9, 2024 that will close this issue
2 tasks
@Xujiayao Xujiayao removed the good first issue Good for newcomers label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants