Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fanart and lowlist to movie details in default skin. #1224

Closed
Omertron opened this issue Mar 15, 2015 · 4 comments
Closed

Add fanart and lowlist to movie details in default skin. #1224

Omertron opened this issue Mar 15, 2015 · 4 comments

Comments

@Omertron
Copy link
Member

Original issue 1225 created by Omertron on 2010-01-28T06:23:30.000Z:

Using YAMJ on a NMT (Popcorn A110).

I have tried to modify the default skin included with YAMJ to include
fanart abilities. I have succeeded to some extent but would like to
request that the lowlist (Top # 250) skin on the detailed movie page was a
possible parameter (true/false), in future versions.

If I can be of any assistance, testing, beta, etc., please let me know as
unfortunatley, I have not been able to succeed in getting the lowlist to
work on my own.

@Omertron
Copy link
Member Author

Comment #1 originally posted by Omertron on 2010-02-10T18:55:55.000Z:

http://www.networkedmediatank.com/showthread.php?tid=35135

@Omertron
Copy link
Member Author

Comment #2 originally posted by Omertron on 2010-02-10T23:46:54.000Z:

I'm not really in favor of this for the 'default' skin, since this is supposed to be
a simple skin for users to start with.

I believe that 5150 skin is like the default but with added features, including fanart.
Even if fanart was to be included in the default skin, it would look awful with the text
in front of it on light backgrounds. It would also need a table background for the
text which is semi-transparent like other skins use.

@Omertron
Copy link
Member Author

Comment #3 originally posted by Omertron on 2010-02-11T07:09:47.000Z:

Yes, and that's what the post above links to.

I think it's a reasonably simple addition to the default skin, that doesn't over
complicate it for first time users.

If it can be coded to add the fanart to the layout whether it's there or not, then it
should look quite nice and if the user doesn't like it, they can always turn it off :)

@Omertron
Copy link
Member Author

Comment #4 originally posted by Omertron on 2010-02-11T20:26:00.000Z:

I think lowlist is a little too much for the default skin, but fanart has been added.

Fixed in r1381

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant