Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comma divider missing when not all fields present in default skins #1283

Closed
Omertron opened this issue Mar 15, 2015 · 1 comment
Closed

Comma divider missing when not all fields present in default skins #1283

Omertron opened this issue Mar 15, 2015 · 1 comment

Comments

@Omertron
Copy link
Member

Original issue 1284 created by Omertron on 2010-02-16T13:30:26.000Z:

in the default skin (haven't checked others) the logic for the comma
divider between genres/runtime/certification/language in the details.xml is
incorrect, instead of 'and', 'or' should be used otherwise the comma will
not be used at all unless all fields have data.

So the following line:
<xsl:if test="count(genres) != 0 and runtime != 'UNKNOWN'">, </xsl:if>
Should be
<xsl:if test="count(genres) != 0 or runtime != 'UNKNOWN'">, </xsl:if>

And the following:
<xsl:if test="count(genres) != 0 and runtime != 'UNKNOWN' and certification
!= 'UNKNOWN'">, </xsl:if>
Should be:
<xsl:if test="count(genres) != 0 or runtime != 'UNKNOWN' or certification
!= 'UNKNOWN'">, </xsl:if>

@Omertron
Copy link
Member Author

Comment #1 originally posted by Omertron on 2010-02-16T20:26:03.000Z:

Thanks for that.

Fixed in all skins r1410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant