Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mjb.xmlGenreFile still working? (r1754) #1571

Closed
Omertron opened this issue Mar 15, 2015 · 14 comments
Closed

mjb.xmlGenreFile still working? (r1754) #1571

Omertron opened this issue Mar 15, 2015 · 14 comments

Comments

@Omertron
Copy link
Member

Original issue 1572 created by Omertron on 2010-08-29T18:32:46.000Z:

Hi,

That feature used to work in the past, but since a few months, it doesn't seem to work anymore.

I have set:
mjb.xmlGenreFile=My_genres.xml

Here's what I have in My_genres.xml:
<genres>
<genre name="Aventure">
<subgenre>Adventure</subgenre>
<subgenre>Action</subgenre>
<subgenre>Action and Adventure</subgenre>
</genre>
<genre name="Guerre">
<subgenre>War</subgenre>
</genre>
<genre name="Drame">
<subgenre>Drama</subgenre>
<subgenre>Comédie dramatique</subgenre>
</genre>
<genre name="Film noir">
<subgenre>Crime</subgenre>
<subgenre>Film-Noir</subgenre>
<subgenre>Thriller</subgenre>
</genre>
<genre name="Mystère">
<subgenre>Mystery</subgenre>
</genre>
<genre name="Musical">
<subgenre>Music</subgenre>
<subgenre>Musique</subgenre>
<subgenre>Comédie musicale</subgenre>
</genre>
<genre name="Fantastique et Science-Fiction">
<subgenre>Science fiction</subgenre>
<subgenre>Science-fiction</subgenre>
<subgenre>Fantastique</subgenre>
</genre>
<genre name="Comédie">
<subgenre>Comedy</subgenre>
<subgenre>Family</subgenre>
<subgenre>Fantasy</subgenre>
<subgenre>Romance</subgenre>
</genre>
<genre name="Erotique">
<subgenre>Adult</subgenre>
<subgenre>Adulte</subgenre>
</genre>
<genre name="Péplum">
<subgenre>Peplum</subgenre>
</genre>
<genre name="Dessin animé">
<subgenre>Animation</subgenre>
</genre>
<genre name="Epouvante">
<subgenre>Horror</subgenre>
<subgenre>Horreur</subgenre>
<subgenre>Epouvante-horreur</subgenre>
</genre>
<genre name="Court-métrage">
<subgenre>Short</subgenre>
<subgenre>Court métrage</subgenre>
<subgenre>Court-metrage</subgenre>
</genre>
<genre name="Divers">
<subgenre>Autres</subgenre>
<subgenre>Expérimental</subgenre>
</genre>
<genre name="Documentaire">
<subgenre>Documentary</subgenre>
</genre>
<genre name="Histoire">
<subgenre>Historique</subgenre>
<subgenre>History</subgenre>
</genre>
<genre name="Biographie">
<subgenre>Biopic</subgenre>
<subgenre>Biography</subgenre>
</genre>
</genres>

Here's what I find after indexing:

Action / Adult / Adventure / Animation / Arts Martiaux / Aventure / Biographie / Biography / Biopic / Comedy / Comédie / Comédie dramatique / Comédie musicale / Court-metrage / Crime / Divers / Documentaire / Documentary / Drama / Drame / Epouvante-horreur / Erotique / Espionnage / Expérimental / Famille / Family / Fantastique / Fantasy / Film-Noir / Guerre / Histoire / Historique / History / Horreur / Horror / Musical / Mystery / Policier / Péplum / Romance / Science fiction / Short / Sous-titres anglais / Sport / Thriller / VO non sous-titrée / War / Western

Thanks for your help.

@Omertron
Copy link
Member Author

Comment #1 originally posted by Omertron on 2010-09-10T00:19:45.000Z:

I just tested this with a few genres, however, I do not have all of those you seem to have, but I copied your example.
It actually seems that to be working fine with the latest build (r1770) on my setup.
When scanning your library, do you notice an error saying something like Invalid byte 2 of 3-byte UTF-8 sequence.? If so, you have to save the My_genres.xml file in the UTF-8 format, otherwise it won't work.

@Omertron
Copy link
Member Author

Comment #2 originally posted by Omertron on 2010-09-10T10:41:24.000Z:

My_genres.xml is already UTF-8 encoded.
I'll try to rebuild the entire library with r1770.
Thanks.

@Omertron
Copy link
Member Author

Comment #3 originally posted by Omertron on 2010-09-10T17:34:33.000Z:

I built from scratch a subset of my movies with r1770. Problem still there...

Action / Animation / Aventure / Biopic / Comédie / Comédie dramatique / Comédie musicale / Crime / Divers / Documentaire / Documentary / Drama / Drame / Epouvante-horreur / Erotique / Espionnage / Famille / Fantastique / Film-Noir / Guerre / Historique / Musical / Policier / Romance / Science fiction / Sous-titres anglais / Thriller / War / Western

@Omertron
Copy link
Member Author

Comment #4 originally posted by Omertron on 2010-09-10T20:10:18.000Z:

Yep, I can confirm this: if you first built your library with a standard genre.xml file and then, without rebuilding the whole library, adding your My_genres.xml file, you will actually see both versions in your library. Not sure if this is a real defect, though. I'll check if this is an intended behavior or not.

@Omertron
Copy link
Member Author

Comment #5 originally posted by Omertron on 2010-09-10T23:24:11.000Z:

This is a real defect. It worked with pre-2.0 releases.
I have not built first my library with a standard genres.xml. As I said, I built it from scratch with my own My_genres.xml.

@Omertron
Copy link
Member Author

Comment #6 originally posted by Omertron on 2010-09-10T23:41:03.000Z:

However, I confirm what you say, but it is not what I have done...

@Omertron
Copy link
Member Author

Comment #7 originally posted by Omertron on 2010-09-11T00:52:07.000Z:

Ok, maybe if I had the structure of your library, I might be able to find out what's wrong with your library's genre.
Download the attached file and save your folder structure to a text file with the integrated function (You need to have the Java Runtime Environment installed in order to start this program. http://java.com/en/download/index.jsp).
If you have done so, either attach it here or send me an email with the file (address is inside the app or use google mail).
I will then recreate my library with your files (0-byte files actually) and check if I can reproduce the issue. If so, I may be able to help fix it, too.

Thanks in advance. :)

@Omertron
Copy link
Member Author

Comment #8 originally posted by Omertron on 2010-09-11T02:36:40.000Z:

Well, I found a workaround to that issue trying to solve someone else's issue!
Amazingly, the bug seems to be skin (Aeon) related. Juste have a look at issue 1574.
If you look at the bottom, I have posted 2 screen captures:

  • Capture1.jpg is what I get with my current configuration files. Here I have the Genres problem (not shown on screen)
  • Capture2.jpg shows what I get after copying to my skins/default/ directory the 2 files that Patrice@gmail.com has uploaded (skin.properties & skin-options.xsl). He uses Aeon too.
    I was surprised to notice that, after rebuilding and indexing from scratch, all my genres were correctly grouped, according to My_genres.xml:
    Aventure / Biographie / Comédie / Dessin animé / Divers / Documentaire / Drame / Epouvante / Erotique / Espionnage / Famille / Fantastique et Science-Fiction / Film noir / Guerre / Histoire / Musical / Policier / Sous-titres anglais / Western

I have uploaded the dump you requested, and my skin.properties & skin-options.xsl (those which give me wrong genres).

For the time being, this is a good workaround for me. I can use that skin. But the bug remains...

Thanks a lot for your help.

@Omertron
Copy link
Member Author

Comment #9 originally posted by Omertron on 2010-09-11T02:51:57.000Z:

To summerize things, when I use the skin shown on Capture1, genres are not grouped.
When I use the skin shown on Capture2, genres are correctly grouped. Both skins are Aeon.

@Omertron
Copy link
Member Author

Comment #10 originally posted by Omertron on 2010-09-11T04:57:34.000Z:

I must be blind... both images show only 1 genre "Drame"
What grouping were you expecting?

@Omertron
Copy link
Member Author

Comment #11 originally posted by Omertron on 2010-09-11T06:28:26.000Z:

In that case, check the skin.properties file and see if it's overwriting the genres.xml setting?

@Omertron
Copy link
Member Author

Comment #12 originally posted by Omertron on 2010-09-11T10:32:21.000Z:

You are right, Stuart!

The guilty is
# Reduce the number of genres
mjb.filter.genres=false

When set to true, My_genres.xml is not used, when set to false, it is!

@Omertron
Copy link
Member Author

Comment #13 originally posted by Omertron on 2010-09-11T10:51:07.000Z:

Sorry, it is the contrary:

mjb.filter.genres=false My_genres.xml is not used

mjb.filter.genres=true My_genres.xml is used

@Omertron
Copy link
Member Author

Comment #14 originally posted by Omertron on 2010-10-14T11:44:04.000Z:

So this is fixed then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant