Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poster.scanner.ValidateMatch not working #1742

Closed
Omertron opened this issue Mar 15, 2015 · 3 comments
Closed

poster.scanner.ValidateMatch not working #1742

Omertron opened this issue Mar 15, 2015 · 3 comments

Comments

@Omertron
Copy link
Member

Original issue 1743 created by Omertron on 2010-12-12T17:29:03.000Z:

When property is set to less than 100, every poster size is considered valid.

I did some test and found that the issue is in PosterScanner.validatePoster method. When adjusting posterWidth and height according to ValidateMatch, they are both se to 0.

posterWidth = posterWidth * (posterValidateMatch / 100);

should be

posterWidth = (posterWidth * posterValidateMatch) / 100;

otherwise, being integers, posterValidateMatch / 100 equals to 0. The same goes for posterHeight.

I fixed it in my local working copy, let me know if I can commit it.

@Omertron
Copy link
Member Author

Comment #1 originally posted by Omertron on 2011-01-03T14:24:27.000Z:

Stuart, did you have time to look into this?

The fix should be very simple (it's running on my local copy with no issue). Anyway, since this is a quite shared piece of code, I'm waiting on a feedback from you before committing it.

@Omertron
Copy link
Member Author

Comment #2 originally posted by Omertron on 2011-01-05T14:10:39.000Z:

Agreed, go ahead and commit the change :)

@Omertron
Copy link
Member Author

Comment #3 originally posted by Omertron on 2011-01-05T15:07:17.000Z:

This issue was closed by revision r2019.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant