You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Original issue 1743 created by Omertron on 2010-12-12T17:29:03.000Z:
When property is set to less than 100, every poster size is considered valid.
I did some test and found that the issue is in PosterScanner.validatePoster method. When adjusting posterWidth and height according to ValidateMatch, they are both se to 0.
Comment #1 originally posted by Omertron on 2011-01-03T14:24:27.000Z:
Stuart, did you have time to look into this?
The fix should be very simple (it's running on my local copy with no issue). Anyway, since this is a quite shared piece of code, I'm waiting on a feedback from you before committing it.
Original issue 1743 created by Omertron on 2010-12-12T17:29:03.000Z:
When property is set to less than 100, every poster size is considered valid.
I did some test and found that the issue is in PosterScanner.validatePoster method. When adjusting posterWidth and height according to ValidateMatch, they are both se to 0.
posterWidth = posterWidth * (posterValidateMatch / 100);
should be
posterWidth = (posterWidth * posterValidateMatch) / 100;
otherwise, being integers, posterValidateMatch / 100 equals to 0. The same goes for posterHeight.
I fixed it in my local working copy, let me know if I can commit it.
The text was updated successfully, but these errors were encountered: