Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always recreating Sets and Categories #1961

Closed
Omertron opened this issue Mar 15, 2015 · 5 comments
Closed

always recreating Sets and Categories #1961

Omertron opened this issue Mar 15, 2015 · 5 comments

Comments

@Omertron
Copy link
Member

Original issue 1962 created by Omertron on 2011-06-04T16:51:09.000Z:

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?
I recently updated to the latest 2.5 beta r2471 and created a fresh jukebox. I've run yamj several times after I've fully created my jukebox with no changes to video files or NFO files and everytime all the Set and category XML and HTML are recreated. I have all the force options set to false.

What version/revision of YAMJ are you using? On what operating system?
r2471

What skin are you using?
ppp2-gfb107-sd (I'm the one that made it)

What device are you using YAMJ on? Networked Media Tank, PlayonHD, Other?
A-100

Please provide any additional information below.

@Omertron
Copy link
Member Author

Comment #1 originally posted by Omertron on 2011-06-06T05:21:01.000Z:

Yes, this is annoying behaviour.

According to NMT support thread, this is because of NEW videos or watched/unwatched videos that may affect these indexes.

Suggestion would be to count for actual changes in the number found. If no new videos and no new changes to watched/unwatched, then no need to touch the indexes.

@Omertron
Copy link
Member Author

Comment #2 originally posted by Omertron on 2011-06-06T06:58:01.000Z:

The issue with the new/watched is that the routine to detect changes to the index looks for movies that have changed. If the index contains no movies that have changed, then it doesn't write the index.

If a movie is unwatched and moves to watched, it doesn't exist in unwatched index and therefore the index isn't written out (because nothing has changed). We don't read the indexes in, so we have no way of knowing that the index has changed.

This is the reason why I took the approach to always re-write these out.

The same or similar goes for sets. Adding a movie to the set doesn't make the movie dirty, so we don't/can't detect the change.

@Omertron
Copy link
Member Author

Comment #3 originally posted by Omertron on 2011-06-07T18:11:29.000Z:

Could some additional effort be put in to finding a better fix for these indexing issues? I have my server setup to update yamj automatically when I add or delete a video. Having that update take 15-20 minutes and pegging my little embedded server is a real bummer. And it will only get worse as my (and everyone elses) video collections grow.

Watched/New: In the very short term, couldn't you just always write out these indexes and not every index.

Sets: A movies XML file contains the list of Sets it belongs to. If this is updated when a movie is added or removed from a set, couldn't that be used to flag which sets to update? You would still have the old and new XML files for a movie.

@Omertron
Copy link
Member Author

Comment #4 originally posted by Omertron on 2011-06-30T07:55:11.000Z:

This issue was closed by revision r2577.

@Omertron
Copy link
Member Author

Comment #5 originally posted by Omertron on 2011-06-30T17:53:28.000Z:

r2578 - Most indexes and all movie sets are still recreated on every run. I've run it several times in a row after upgrading. Not Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant