Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All plugins run when not enabled #2145

Closed
Omertron opened this issue Mar 15, 2015 · 15 comments
Closed

All plugins run when not enabled #2145

Omertron opened this issue Mar 15, 2015 · 15 comments

Comments

@Omertron
Copy link
Member

Original issue 2146 created by Omertron on 2011-10-28T07:58:01.000Z:

What steps will reproduce the problem?
1.Use latest 2732 yamj
2.Start a scan it runs through every plugin even ones not enabled.

@Omertron
Copy link
Member Author

Comment #1 originally posted by Omertron on 2011-10-28T08:10:16.000Z:

log snippet

[00:51:20 - Thread-5] NFOScanner: Scanning NFO file for IDs: weeds.s01e01.nfo
[00:51:20 - Thread-5] Scanning NFO for Imdb Id
[00:51:21 - Thread-6] No IMDb Id found in nfo !
[00:51:21 - Thread-6] AllocinePlugin: Scanning NFO for Allocine Id
[00:51:21 - Thread-6] AllocinePlugin: No Allocine Id found in nfo !
[00:51:21 - Thread-6] Scanning NFO for Animator Id
[00:51:21 - Thread-6] No Animator Id found in nfo !
[00:51:21 - Thread-6] Scanning NFO for Imdb Id
[00:51:24 - Thread-6] No IMDb Id found in nfo !
[00:51:24 - Thread-6] Scanning NFO for Imdb Id
[00:51:25 - Thread-5] No IMDb Id found in nfo !
[00:51:25 - Thread-5] Scanning NFO for Imdb Id
[00:51:26 - Thread-4] No IMDb Id found in nfo !
[00:51:26 - Thread-4] Scanning NFO for filmweb url
[00:51:26 - Thread-4] No filmweb url found in nfo !
[00:51:26 - Thread-4] Scanning NFO for Imdb Id
[00:51:27 - Thread-6] No IMDb Id found in nfo !
[00:51:27 - Thread-6] No ComingSoon Id found in nfo!
[00:51:27 - Thread-6] Scanning NFO for Imdb Id
[00:51:30 - Thread-6] No IMDb Id found in nfo !
[00:51:30 - Thread-6] FilmDeltaSE: plugin created..
[00:51:30 - Thread-6] Scanning NFO for Imdb Id
[00:51:32 - Thread-6] No IMDb Id found in nfo !
[00:51:32 - Thread-6] FilmDeltaSEPlugin: Scanning NFO for Filmdelta Id
[00:51:32 - Thread-6] FilmdeltaSEPlugin: no id found in nfo for movie: UNKNOWN
[00:51:32 - Thread-6] Scanning NFO for Imdb Id
[00:51:32 - Thread-5] No IMDb Id found in nfo !
[00:51:32 - Thread-5] AllocinePlugin: Scanning NFO for Allocine Id
[00:51:32 - Thread-5] AllocinePlugin: No Allocine Id found in nfo !
[00:51:32 - Thread-5] Scanning NFO for Animator Id
[00:51:32 - Thread-5] No Animator Id found in nfo !
[00:51:32 - Thread-5] Scanning NFO for Imdb Id
[00:51:34 - Thread-4] No IMDb Id found in nfo !
[00:51:34 - Thread-4] Scanning NFO for Kinopoisk Id
[00:51:34 - Thread-4] No Kinopoisk Id found in nfo !
[00:51:34 - Thread-4] Scanning NFO for Imdb Id
[00:51:35 - Thread-6] No IMDb Id found in nfo !
[00:51:35 - Thread-6] Scanning NFO for Imdb Id
[00:51:38 - Thread-6] No IMDb Id found in nfo !
[00:51:38 - Thread-6] Scanning NFO for Filmup Id
[00:51:38 - Thread-6] No Filmup Id found in nfo !
[00:51:38 - Thread-6] WebBrowser: Requesting http://www.filmweb.pl
[00:51:39 - Thread-5] No IMDb Id found in nfo !
[00:51:39 - Thread-5] Scanning NFO for Imdb Id
[00:51:39 - Thread-4] No IMDb Id found in nfo !
[00:51:39 - Thread-4] MovieMeterPluginSession: Getting stored session
[00:51:39 - Thread-4] MovieMeterPluginSession: Stored session: 0pkwynnx8sxk2padxux373hktvuswkcm5e685cec0ead680c0a1a091e1d73a7$
[00:51:39 - Thread-4] MovieMeterPlugin: Scanning NFO for Moviemeter Id
[00:51:39 - Thread-4] MovieMeterPlugin: No Moviemeter Id found in nfo !

@Omertron
Copy link
Member Author

Comment #2 originally posted by Omertron on 2011-10-28T08:27:50.000Z:

<empty>

@Omertron
Copy link
Member Author

Comment #3 originally posted by Omertron on 2011-10-28T09:34:21.000Z:

This is a sign of auto-detect the scanner on NFO file.

@Omertron
Copy link
Member Author

Comment #4 originally posted by Omertron on 2011-10-28T09:37:39.000Z:

only problem is its hitting every website its not just checking the nfo its trying to grab from movemeter and filmweb for no reason even when not enabled. Scan time when from 15 minutes to 2 hours with the change.

@Omertron
Copy link
Member Author

Comment #5 originally posted by Omertron on 2011-10-28T09:44:09.000Z:

Show me file weeds.s01e01.nfo

@Omertron
Copy link
Member Author

Comment #6 originally posted by Omertron on 2011-10-28T09:49:09.000Z:

only thing in it is

       Title: Weeds S01E01 You Can't Miss the Bear
       Release Date : 04/19/2007
       Airdate : 08/07/2005
       Format : XVID
       Video Bitrate : 933 kb/s
       Resolution : 640x352 (1.82:1)
       FPS : 25 fps
       Source : DVD
       Audio Formate : 132 kb/s (66/ch, stereo) VBR  

       http://www.tv.com/weeds/show/28829/summary.html

I dont use full nfo files. unless it cant find it on tvdb then i throw in the link to tvdb site.

@Omertron
Copy link
Member Author

Comment #7 originally posted by Omertron on 2011-10-28T09:53:56.000Z:

attach entire log

@Omertron
Copy link
Member Author

Comment #8 originally posted by Omertron on 2011-10-28T10:03:08.000Z:

This issue was updated by revision r2736.

new option:
mjb.internet.plugin.autodetect = true/false - auto-detect the scanner on NFO file

@Omertron
Copy link
Member Author

Comment #9 originally posted by Omertron on 2011-10-28T10:03:46.000Z:

try scan with
mjb.internet.plugin.autodetect=false

@Omertron
Copy link
Member Author

Comment #10 originally posted by Omertron on 2011-10-28T10:23:22.000Z:

I was wondering if there was a possibility to do a list like poster.searchpriority.

So you could check to see if the plugin was on that list before you scanned for it.

So plugin.autodetect.priority=imdb,themoviedb,allocine,filmaffinity

Then it would only scan those plugins (assuming that they were valid for the particular type: movie/tv)

This means that someone who doesn't want to ever use a French (Allocine) or Russian (Kinospk) plugin would still benefit from the autodetect

@Omertron
Copy link
Member Author

Comment #11 originally posted by Omertron on 2011-10-28T17:23:25.000Z:

Updated by r2736 & r2737

@Omertron
Copy link
Member Author

Comment #12 originally posted by Omertron on 2011-10-28T17:50:53.000Z:

This issue was updated by revision r2738.

Added property to default properties file

@Omertron
Copy link
Member Author

Comment #13 originally posted by Omertron on 2011-10-31T06:14:15.000Z:

I suggest using the parameter mjb.internet.plugin.autodetect for limiting the plugin:
false - switch off feature
true - use all
imdb,themoviedb,allocine,filmaffinity - use this list

@Omertron
Copy link
Member Author

Comment #14 originally posted by Omertron on 2011-10-31T06:27:27.000Z:

That sounds good.

Also, I think the property should default to "false" and then you can change it if you want. That way it doesn't slow the scanning down for people that don't need it.

The NFO page can be updated with this property to indicate it's use as well

@Omertron
Copy link
Member Author

Comment #15 originally posted by Omertron on 2011-10-31T09:17:27.000Z:

This issue was closed by revision r2744.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant