writer item is empty (in categories.xml) when mjb.people=false

[Omertron]

Original issue 2172 created by Omertron on 2011-11-06T09:47:43.000Z:

What steps will reproduce the problem?
1.yamj xml step
2.categories.xml generation
3.

What is the expected output? What do you see instead?
when mjb.people=false inside categories.xml writer categories index is empty
<category name="Writer" count="10"
></category>
when mjb.people=true inside categories.xml writer categories index is filled with item
<category name="Writer" count="13">
<index name="Chris Miller (II)" originalName="Chris Miller (II)" filename="Writer_Chris Miller (II)_1">
<movie>26</movie>
<movie>28</movie>
</index>
<index name="Cody Cameron" originalName="Cody Cameron" filename="Writer_Cody Cameron_1">
<movie>26</movie>
<movie>28</movie>
</index>
<index name="Conrad Vernon" originalName="Conrad Vernon" filename="Writer_Conrad Vernon_1">
<movie>26</movie>
<movie>28</movie>
</index>
<index name="Craig Sweeny" originalName="Craig Sweeny" filename="Writer_Craig Sweeny_1">
<movie>31</movie>
</index>
<index name="Glenn Gordon Caron" originalName="Glenn Gordon Caron" filename="Writer_Glenn Gordon Caron_1">
<movie>31</movie>
</index>
<index name="Joe Stillman" originalName="Joe Stillman" filename="Writer_Joe Stillman_1">
<movie>26</movie>
<movie>28</movie>
</index>
<index name="Kelly Asbury" originalName="Kelly Asbury" filename="Writer_Kelly Asbury_1">
<movie>26</movie>
<movie>28</movie>
</index>
<index name="Marc Cherry" originalName="Marc Cherry" filename="Writer_Marc Cherry_1">
<movie>30</movie>
</index>
<index name="Robert Doherty" originalName="Robert Doherty" filename="Writer_Robert Doherty_1">
<movie>31</movie>
</index>
<index name="Roger S.H. Schulman" originalName="Roger S.H. Schulman" filename="Writer_Roger S.H. Schulman_1">
<movie>26</movie>
<movie>28</movie>
</index>
<index name="Ted Elliott" originalName="Ted Elliott" filename="Writer_Ted Elliott_1">
<movie>25</movie>
<movie>26</movie>
<movie>28</movie>
</index>
<index name="Terry Rossio" originalName="Terry Rossio" filename="Writer_Terry Rossio_1">
<movie>25</movie>
<movie>26</movie>
<movie>28</movie>
</index>
<index name="Tony Gilroy" originalName="Tony Gilroy" filename="Writer_Tony Gilroy_1">
<movie>32</movie>
</index>
</category>
What version/revision of YAMJ are you using? On what operating system?
R2773

What skin are you using?
not dependant of the skin

What device are you using YAMJ on? Networked Media Tank, PlayonHD, Other?
C200

Please provide any additional information below.

[Omertron]

Comment #1 originally posted by Omertron on 2011-11-14T14:40:10.000Z:

This issue was closed by revision r2788.

[Omertron]

Comment #2 originally posted by Omertron on 2011-11-14T22:51:47.000Z:

tested with r2789 and it's KO ==> no writer entry generated in category section inside categories.xml while mjb.people=false

[Omertron]

Comment #3 originally posted by Omertron on 2011-11-15T13:45:51.000Z:

Is that a pass or a fail?

I don't use people, so if this is not fixed I need a small test library (Just the properties you need to set and a few films that will indicate the problem)

[Omertron]

Comment #4 originally posted by Omertron on 2011-11-15T20:55:42.000Z:

yes it's failed
you could test with any empty movies doesn't mater everytime it's empty

• shrek
• One Eight Seven
• Die Hard 2

[Omertron]

Comment #5 originally posted by Omertron on 2011-11-23T21:34:03.000Z:

Tested with r2805 and works fine

mjb.categories.minCount=2
mjb.categories.minCount.Writer=1
mjb.people=false

Writer_Scott Yagemann_1 Writer_Walter Wager_1 Writer_William Steig_1

[Omertron]

Comment #6 originally posted by Omertron on 2011-11-23T22:57:29.000Z:

carefull with the test you maid,
1 - because of the issue (2171) where categories.xml file isn't overwriten even if overwritenIndex=true, the contents the categories.xml could be an old one.
2 - because of the issue (2170) if -h is selected (or setted to skip html generation in moviejuekebox.properties) the contents of teh categories.xml file isn't the same than with html generation

i redo the test with,

• R2805,
• mjb.people=false
• first deleting categories.xml and categories.html
• without -h option
  and i confirm that the isn't present in the xml file

[Omertron]

Comment #7 originally posted by Omertron on 2011-11-24T07:26:15.000Z:

I did the jukebox from scratch. No categories file.

Which XML file are you talking about?

[Omertron]

Comment #8 originally posted by Omertron on 2011-11-24T16:22:22.000Z:

i'm talking about Categories.xml file
attached Categories with people_true.xml - lines 10409 and bellow 'writer' categories is present
attached Categories with people_false.xml - lines 10414 and bellow 'writer' categories is missing (should be beetween end of person categories and certification categories)

and it's the same with all other index xml file
attached Other_all_1 with people_true.xml writer categories is present line 56
attached Other_all_1 with people_false.xml writer categories is misssing (should be placed beetween library and cast)

[Omertron]

Comment #9 originally posted by Omertron on 2011-11-25T18:33:55.000Z:

This issue was closed by revision r2811.

[Omertron]

Comment #10 originally posted by Omertron on 2011-11-25T20:03:30.000Z:

sorry just tested with R2811 and writer still empty no writer entry
look at attach file categories.xml

[Omertron]

Comment #11 originally posted by Omertron on 2011-11-25T20:52:29.000Z:

This works for me. The original error was that writers was not created in the categories.xml file when mjb.people=false.

I tested with the following settings:
mjb.people.popularity=1
mjb.categories.minCount=2
mjb.categories.minCount.Writer=1
mjb.people=false
mjb.categories.indexList=Other,Genres,Title,Certification,Year,Library,Set,Writer,Director

[Omertron]

Comment #12 originally posted by Omertron on 2011-11-25T21:17:47.000Z:

tested with
mjb.people=false
mjb.people.popularity=2
mjb.people.maxCount=100
plugin.people.maxCount=13
plugin.people.maxCount.director=2
plugin.people.maxCount.writer=1
plugin.people.maxCount.actor=10
mjb.includePhoto=true
mjb.forcePhotoOverwrite=false
plugin.biography.maxlength=400
plugin.filmography.max=17
indexing.completePerson=true
mjb.people.folder=People
(without -h parameter)
==> no writer entry (cast, person, director, are OK), should be present as director

same parameter, except mjb.people=true

==> writer entry is present

so for me it's wrong when mjb.people=false , do i misunderstand something ?

[Omertron]

Comment #13 originally posted by Omertron on 2011-11-26T15:10:57.000Z:

If mjb.people=true, then the writer list is generated from the people list which may have more writers in it than the "normal" cast list and therefore you'll get more writers and consequently you'll have the entries in categories and other_all

If mjb.people=false; you will use the standard scraping for writers and there are usually less associated with movies, and you are less likely to get them listed in the categories.

Either way, mjb.categories.minCount.Writer=? or mjb.categories.minCount=? is what controls how many writers are indexed.

[Omertron]

Comment #14 originally posted by Omertron on 2011-11-26T15:47:22.000Z:

i agree with what you explain, with my test jukebox , i have inside 15 episode of desparate housewifes, with my moviejukebox.properties mjb.categories.minCount=2 so even if mjb.people=false i thought that i should have almost twice the same writer for one valid entry for writer, and it's wasn't the case

so (just after your very good explanation) i made a test with mjb.categories.minCount=1 this setting supposed 1 entry for each writer.

==> 7 entries with 7 writers and each writer point to only one TV show (that would say, there is no reason to appears if mjb.categories.minCount=2)

apologies for all theses complains, this issue is really to be closed with R2788
great job and thanks again for your patience

[Omertron]

Comment #15 originally posted by Omertron on 2011-11-26T17:48:26.000Z:

That is fine. I'd rather have someone who knows this area ask questions and challenge when they think it is wrong!