Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TVSHOWNAME.nfo is not correctly generating titles #2190

Closed
Omertron opened this issue Mar 15, 2015 · 9 comments
Closed

TVSHOWNAME.nfo is not correctly generating titles #2190

Omertron opened this issue Mar 15, 2015 · 9 comments

Comments

@Omertron
Copy link
Member

Original issue 2191 created by Omertron on 2011-11-14T23:57:43.000Z:

What steps will reproduce the problem?

  1. Create a TVSHOWNAME.nfo and put it in the TV show folder, but not in the Season folders.
  2. Run YAMJ.
  3. Show name is incorrect.

What is the expected output? What do you see instead?
I expect it to use the name I put in TVSHOWNAME.nfo, or at least use the name that is on TVDB. I explained it here much better: http://www.networkedmediatank.com/showthread.php?tid=56383

I've attached 2 NFOs that I use, so if you have the series or want to create dummy files to test.

What version/revision of YAMJ are you using? On what operating system?
r2879

What skin are you using?
Eversion

What device are you using YAMJ on? Networked Media Tank, PlayonHD, Other?
A300/A200

Please provide any additional information below.

Few shows that I know are affected, some shows are not:
WWII in HD gets renamed as WWII in.
Archer (2009) gets renamed as Archer.
Law & Order: Special Victims Unit gets renamed as Law & Order - Special Victims Unit.
Life (2009) gets renamed as Life.
Louie (2010) gets renamed as Louie.

@Omertron
Copy link
Member Author

Comment #1 originally posted by Omertron on 2011-11-15T18:52:47.000Z:

Try to not write the Year in brackets() that may solve the year not showing in the name.
The First is most likely because HD is recognised as a categorie and thatfore stripped from the name, for the third one i believe the ":" is stripped due to filename reasons.
The seriesname.xml file would have to contain that ":" and thats not possible on most filesystems.

@Omertron
Copy link
Member Author

Comment #2 originally posted by Omertron on 2011-11-16T00:46:49.000Z:

  1. The year in the filename is how TVDB shows it, I have always used exactly what they use and never had this problem. Removing the NFO file fixes the naming, even with year in the title.

  2. Same as above, WWII in HD correctly shows up as its real name if TVSHOWNAME.nfo is removed. So if that's what its doing, it's a bug when TVSHOWNAME.nfo exists.

  3. All my shows that have ":" in them correctly show it when TVSHOWNAME.nfo doesn't exist, so if its possible without local NFOs, it should be possible with them too?

@Omertron
Copy link
Member Author

Comment #3 originally posted by Omertron on 2011-11-16T14:51:59.000Z:

WWII in HD is a bug. The HD was being removed from the title before being accepted as a title. I've moved the HD detection (along with FPS, Audio and video codec detection) to the end of the list, so this should solve the issue (although it might cause some others)

The rest work as expected. The name of the show is "Life" not "Life (2009)". You are correct in using "Life (2009)" to help identify it from the tvdb, but that is the correct name of the show.

@Omertron
Copy link
Member Author

Comment #4 originally posted by Omertron on 2011-11-16T14:53:05.000Z:

This issue was closed by revision r2791.

@Omertron
Copy link
Member Author

Comment #5 originally posted by Omertron on 2011-11-17T10:51:55.000Z:

It's not fixed with r2791. Still says "WWII in".

I believe this is issue is not caused by what you claim it is. If it was HD detection, it would happen with and without the NFOs (to my knowledge). So i'll give another example...

Without the NFOs:
WWII in HD
Life (2009)
Archer (2009)
Law and Order: Special Victims Unit

With the NFOs:
WWII in
Life
Archer
Law and Order - Special Victims Unit

As you can see in the NFOs attached above, NOTHING in the NFOs is specify these title names. They shouldn't be changing at all unless I tell them too.

Why is it ignoring the title name that is in the NFO? Why is it changing the titles when i'm not telling it too?

@Omertron
Copy link
Member Author

Comment #6 originally posted by Omertron on 2011-11-17T12:51:56.000Z:

Please re-read my comment # 3 re Life & Archer
In the XML for the movie these are the fields:

  <title>Life of squigles (2009)</title>
  <titleSort>Life of squigles (2009)</titleSort>
  <originalTitle>Life</originalTitle>

Note: I changed the title field of the NFO to read "Life of squigles (2009)" to prove that the field was being used.

Your skin is using the originalTitle for it's data.

@Omertron
Copy link
Member Author

Comment #7 originally posted by Omertron on 2011-11-17T20:42:25.000Z:

Hmmm... So the problem is with Eversion then? I tried adding OriginalTitle to my NFOs, but it doesn't seem to change the originaltitle. The wierd thing to me is that is doesn't use originaltitle if the NFOs aren't present.

Is there a skin settings to toggle this, or is it something Accident is going to have to change?

Thanks.

@Omertron
Copy link
Member Author

Comment #8 originally posted by Omertron on 2011-11-17T20:56:06.000Z:

I assume the skin is using "originalTitle" as the default rather than "title"
Best to ask a question of the skin author

@Omertron
Copy link
Member Author

Comment #9 originally posted by Omertron on 2011-11-18T11:42:17.000Z:

This issue was closed by revision r2794.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant