Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

People scanner is never launch (with r3387 all is fine) #2553

Closed
Omertron opened this issue Mar 16, 2015 · 18 comments
Closed

People scanner is never launch (with r3387 all is fine) #2553

Omertron opened this issue Mar 16, 2015 · 18 comments

Comments

@Omertron
Copy link
Member

Original issue 2554 created by Omertron on 2012-12-23T01:51:07.000Z:

What steps will reproduce the problem?

With r3387 scanner people works well

With r3392 people scanner is never launch

there is nothing:

  • no directory people
  • no xml file people
  • no poster people
  • no error

I will make more test for look at with which release this is appeared

My config:
eversion r0179 + evZap 1.2.1 + Mod People 5.3 Fr
windows 8 x64 + java 1.7.0.09

@Omertron
Copy link
Member Author

Comment #1 originally posted by Omertron on 2012-12-23T09:39:59.000Z:

This bug appear with r3389.

I did all the test with a empty jukeboxe.

@Omertron
Copy link
Member Author

Comment #2 originally posted by Omertron on 2012-12-23T12:03:21.000Z:

Your right Nicolas; was introduced with the priority checks.

Reason is a behaviour from the previous plugins.
When for Actors "addActor(actorName)" has ben used, then the actor was added
to the cast, but not to the people.
If setCast(actorList) has been used, then the actor was added to the cast
and also with unknown key and role to the people.

I will change the scraping of people, so that the bvehaviour before the priority
checks will come back.

@Omertron
Copy link
Member Author

Comment #3 originally posted by Omertron on 2012-12-23T13:01:28.000Z:

This issue was closed by revision r3408.

@Omertron
Copy link
Member Author

Comment #4 originally posted by Omertron on 2012-12-23T13:06:47.000Z:

Now the people should be scrapped again.

Please use the last YAMJ snapshot and generate the jukebox
again. I think it's not necessary to clear the whole jukebox,
cause if you have people sraping enabled and no people are
scraped, then a recheck will be done.

@Omertron
Copy link
Member Author

Comment #5 originally posted by Omertron on 2012-12-23T15:03:23.000Z:

tested with R3409, now people are scanned, but only 1 people per category for each movie - 1 actor, 1 writer, 1 director

even if properties are setted as:
plugin.people.maxCount.director=2
plugin.people.maxCount.writer=1
plugin.people.maxCount.actor=10

(modification mjb.people.popularity have no effect)

@Omertron
Copy link
Member Author

Comment #6 originally posted by Omertron on 2012-12-23T15:22:16.000Z:

I have the same problem as jean luc.
(test with a empty jukeboxe)

@Omertron
Copy link
Member Author

Comment #7 originally posted by Omertron on 2012-12-23T18:25:43.000Z:

<empty>

@Omertron
Copy link
Member Author

Comment #8 originally posted by Omertron on 2012-12-23T20:09:17.000Z:

This issue was closed by revision r3411.

@Omertron
Copy link
Member Author

Comment #9 originally posted by Omertron on 2012-12-23T20:12:47.000Z:

Fixed again ... now the max-values will be regarded correctly.

Reason was mainly a Copy&Paste error.
Added a test class to check if anything works;
also an enhancements with possible duplicates.

Sorry for the circumstances; think I shouldn't fix
anything after midnight.

@Omertron
Copy link
Member Author

Comment #10 originally posted by Omertron on 2012-12-23T22:05:16.000Z:

this works very well now.
Thank you :)

PS: I am very impressed with the amount and speed of your work

@Omertron
Copy link
Member Author

Comment #11 originally posted by Omertron on 2012-12-23T22:57:43.000Z:

Perhaps you've investigated that the originalTitle is not very good;
until now it's always the filename; you can see it, if you look int the movie xml.

A simple check was missing; will be fixed in the next minutes.

@Omertron
Copy link
Member Author

Comment #12 originally posted by Omertron on 2012-12-23T23:06:05.000Z:

This issue was updated by revision r3413.

Fixed false overwrite check when no priority has been set for actual source

@Omertron
Copy link
Member Author

Comment #13 originally posted by Omertron on 2012-12-23T23:52:20.000Z:

tested with R3412
i could confirm that people (person) are now scanned, but it needed to delete xml first to update the people section.
when popularity=-1 all person are scanned for all movies even if the person has been already scanned earlier in the yamj run
i thought that mjb.internet.person.plugin=com.moviejukebox.plugin.AllocinePlugin should try to scrap person from allocine ? seems to be scrapped always from imb

@Omertron
Copy link
Member Author

Comment #14 originally posted by Omertron on 2012-12-24T00:35:07.000Z:

you were right about OriginaTitle.
I have make a test with r3413.
this is fixed.

@Omertron
Copy link
Member Author

Comment #15 originally posted by Omertron on 2012-12-24T00:41:44.000Z:

Me too with R3413 - originaltitle is OK

:) great work - thanks

@Omertron
Copy link
Member Author

Comment #16 originally posted by Omertron on 2012-12-24T01:04:42.000Z:

Jean Luc,

there is only 2 plugin possible for person: imdb or Kinopoisk
see: http://code.google.com/p/moviejukebox/wiki/Plugins

mjb.internet.person.plugin=com.moviejukebox.plugin.AllocinePlugin is not possible actually.
there is some request in this way. (2046 or 2345) but nothing has moved from.

or I missed something :)

sorry for this off topic

@Omertron
Copy link
Member Author

Comment #17 originally posted by Omertron on 2012-12-24T08:26:50.000Z:

nicolas, it's not what is written under PriorityChecks wiki http://code.google.com/p/moviejukebox/wiki/PriorityChecks
within this wiki, now allocine is a valid value under Actors Person, Writer Person and should be used when priority is set to PLUGIN

but perhaps i misunderstand the wiki. :(

@Omertron
Copy link
Member Author

Comment #18 originally posted by Omertron on 2012-12-24T11:54:16.000Z:

Hi Jean-Luc,
Nicolas has described it correctly.

Person informations will until now only be scraped from IMDB or Kinopoisk.
If you set the AllocinePlugin for people scanner then the IMDB person search will
be used, cause AllocinePlugin extends ImdbPlugin but has no own routine for people scanning; so implicity the people will be scraped from IMDB.

The PriorityCheck are for another kind of scraping, cause there are 2 "people scraping" mechanism; which was introduced with the people enhancements.

1.) Actors, writers, directory for the movie side; this are the priorities i.e.
priority.movie.actors; where you can define from which source ths actors on the movie page should come from.

2.) Along with the movie the "people" must be filled, cause only the set "people" in
a movie do affect the people scanner. No people, nothinh to do for the people scanner. This one was missing when implementing the prirotiy checks but has ben fixed with this issue.

The priority checks only defines the priority of a scanner/plugin in order to determin if a scanner/plugin may or may not override a previously set value by another plugin/scanner.

The People scanning mechanism is not affected by this, so at the moment you only will have people informations from IMDB or KINOPOISK.
With the priority checks you can on the other hand define, that the people scanner should operate at the people found on "allocine" page or "imdb" page or whatever you use for the corresponding priorities.

I hope this helps you.

This issue is fixed now; if you have any other issues or enhancment request, then please create a new issue, so that the developers can track the issues; cause mostly alread fixed issues will not be regarded any more.

And now:
Merry christmas!
Felix Navidad!
Frohe Weihnachten!
God Joel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant