Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mediainfo if filename extension has changed don't work from r3389 #2563

Closed
Omertron opened this issue Mar 16, 2015 · 8 comments
Closed

Comments

@Omertron
Copy link
Member

Original issue 2564 created by Omertron on 2013-01-03T16:47:54.000Z:

What steps will reproduce the problem?

If I use mediainfo.override.values=all mediainfo is updated if filename extension has changed (with r3246).
With r3389 and after mediainfo.override.values=all has no effect.

I have keep all PriorityChecks to default value.

@Omertron
Copy link
Member Author

Comment #1 originally posted by Omertron on 2013-01-03T18:11:52.000Z:

Then you haven't a look into the "Outdated configuration values" section
on the PriorityChecks wiki page.

With the new priority checks there was no needance for the property "mediainfo.override.values" anymore, cause this can be done in the same
way with the priority checks in a more flexible way.

But you have to set following property in your moviejukebox.properties:
mediainfo.update.enable=true
Perhaps you have to delete the movie.xml and movie.html in order to retrieve the mediainfo changes; but first you can try it without deletion.

If some value is grabbed from another source than MEDIAINFO (see movie.xml to check the source of the values), then you should change the priority checks to your needance. Normally the mediainfo value is priorized after the NFO and before any plugin (like IMDB or allocine in your case).

@Omertron
Copy link
Member Author

Comment #2 originally posted by Omertron on 2013-01-03T18:30:38.000Z:

<empty>

@Omertron
Copy link
Member Author

Comment #3 originally posted by Omertron on 2013-01-03T18:56:09.000Z:

<empty>

@Omertron
Copy link
Member Author

Comment #4 originally posted by Omertron on 2013-01-03T22:16:30.000Z:

Of course I have read PriorityChecks wiki page before post
Sorry if I m very confused in my explain. :(

In fact I have try both:
mediainfo.override.values=all
mediainfo.update.enable=true

I have make new test with:

  • mediainfo.update.enable=true
  • no change in prority check
  • no file nfo
  • a empty jukebox
  • r3428

In first time I have a movie SD "Albert Nobbs (2011) VOST.avi"
I run Yamj

After I replace "Albert Nobbs (2011) VOST.avi" with a movie HD "Albert Nobbs (2011) VOST.mkv"
I re run Yamj

There is no change in file "Albert Nobbs (2011) VOST.xml" about mediainfo only this:

  • 2013-01-03 22:55:45
  • 2012-12-09
  • 2,19 GB
  • D:\UwAmp\test_video\DRAME\Albert Nobbs (2011) VOST.mkv

I have try this parameter in moviejukebox.properties without success:

priority.movie.resolution=mediainfo
priority.tv.resolution=mediainfo

Yamj scan the media info only if I delete file xml.
But It is not the normal use or I understand nothing with new setting :/

thanks

@Omertron
Copy link
Member Author

Comment #5 originally posted by Omertron on 2013-01-04T07:50:01.000Z:

OK,
I will try to find the bug and how this issue could be solved.

@Omertron
Copy link
Member Author

Comment #6 originally posted by Omertron on 2013-01-04T19:30:40.000Z:

Hi Nicolas,
I've retested it but in my case it works.

  • Latest YAMJ release 3433
  • Set: mediainfo.update.enable=true
  • Default priority checks (no changes)
  • No NFO file (also tested with NFO file)
  • Empty jukebox

1.) Used a sample AVI file and renamed to "Albert Nobbs (2011) VOST.avi"
First YAMJ run.

2.) Deleted "Albert Nobbs (2011) VOST.avi" and used an MKV test file and renamed it to "Albert Nobbs (2011) VOST.mkv" in the same jukebox directory.
Second YAMJ run.

The Log file is as expected, the last line here is relevant; cause then MediaInfo values will be rechecked.
[20:13:53 - Thread-1] Checking existing video: Albert Nobbs (2011) VOST
[20:13:53 - Thread-1] XML file found for Albert Nobbs (2011) VOST
[20:13:53 - Thread-1] XMLReader: Missing video file in the XML file (Albert Nobbs (2011) VOST.avi), it may have been moved or no longer exist.
[20:13:53 - Thread-1] RecheckScanner: Checking Albert Nobbs (2011) VOST
[20:13:53 - Thread-1] RecheckScanner: Albert Nobbs (2011) VOST - XML is 0 days old, less than recheckMinDays (14), not checking.
[20:13:53 - Thread-1] MediaInfoScanner: Main movie file has changed; rescan media info

The movie.xml has changed, see attached diff between both files: the old XML and the new XML file. The - and + describes exactly what has been deleted or added.

So I cannot see any failure or bug.
Also there are no relevant source changes for this issue between r3428 and r3433.

@Omertron
Copy link
Member Author

Comment #7 originally posted by Omertron on 2013-01-04T20:52:25.000Z:

You are right.
I made a typo in mediainfo.update.enable=true
this is so stupid. :(
Thank you very much for your time and your help.
I m sorry again.

@Omertron
Copy link
Member Author

Comment #8 originally posted by Omertron on 2013-01-04T20:54:14.000Z:

<empty>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant