Error parsing TrailerLastScan from XML

[Omertron]

Original issue 2578 created by Omertron on 2013-01-09T13:50:28.000Z:

When reading TrailerLastScan from existing XML, the string is parsed and converted to seconds, but when checking if trailer rescan is needed, TrailerScanner.isTrailersNeedRescan() is comparing this value with current time and trailersRescanDaysMillis both in milliseconds.

So, if trailers.rescan.days option is enabled, in my experience movies missing trailers are rescanned on each YAMJ run.

This bug was probably introduced in r3236 when Movie class was modified to use new DateTime class.

A simple patch is ready to be committed.

[Omertron]

Comment #1 originally posted by Omertron on 2013-01-09T17:22:59.000Z:

Bug should be fixed by changing

setTrailerLastScan(DateTime.parse(lastScan).getSeconds());
to
setTrailerLastScan(DateTime.parse(lastScan).toMillis());

in method Movie.setTrailerLastScan(String lastScan)

However, given that this has been introduced more than a month ago and I haven't found any open issue about trailer rescan, can somebody else confirm that this is correct?

[Omertron]

Comment #2 originally posted by Omertron on 2013-01-09T19:52:48.000Z:

I don't use the trailer (re)scanning, but that looks right

[Omertron]

Comment #3 originally posted by Omertron on 2013-01-10T09:06:50.000Z:

This issue was closed by revision r3480.