Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TV] and [HD] Overlays not applied to first season in a series. #530

Closed
Omertron opened this issue Mar 15, 2015 · 17 comments
Closed

[TV] and [HD] Overlays not applied to first season in a series. #530

Omertron opened this issue Mar 15, 2015 · 17 comments

Comments

@Omertron
Copy link
Member

Original issue 531 created by Omertron on 2009-02-17T06:25:09.000Z:

What steps will reproduce the problem?

  1. Run r738 with more then one season in a TV series.

What is the expected output? What do you see instead?
[TV] and [HD] logos applied to images for all seasons.

What version of the product are you using? On what operating system?
r738 (I haven't tested r743 but its not listed in the release notes as
resolved)

Please provide any additional information below.
TV series with only one season existing generate the images normally with
the [TV] and [HD] logos applied.

I tested by renaming multiple files from multiple seasons and in every
instance in the event more then one season is present the first does not
get the image overlays applied.

Examples:
Heroes S1 - overlays missing.
Heroes S2 - overlays applied as expected.
Heroes S3 - overlays applied as expected.
Sarah Connor S1 - overlays missing.
Sarah Connor S2 - overlays applied as expected.
Family Guy S3 - overlays missing.
Family Guy S4 - overlays applied as expected.

Its not season one, but rather the first season present. With my Family Guy
Season 3 was the first I have, so its season 3 missing the overlays.

@Omertron
Copy link
Member Author

Comment #1 originally posted by Omertron on 2009-02-23T05:56:04.000Z:

Yes, I can confirm this bug -- exactly as described above.

@Omertron
Copy link
Member Author

Comment #2 originally posted by Omertron on 2009-02-26T03:36:39.000Z:

I can't seem to duplicate. Does it matter if singleSeriesPage is on or off? What skin?

@Omertron
Copy link
Member Author

Comment #3 originally posted by Omertron on 2009-02-26T07:17:16.000Z:

Yes, singleSeriesPage is true and tested with robinjexcal (modified up to date).

When I see a TV series cover page, same as 1st season found, it has no TV logo and
shows as a movie, because it seems that season <= 0
When I click the cover I can see the 2-3 seasons listed, but the first one has no TV
icon on it and all others look fine.

@Omertron
Copy link
Member Author

Comment #4 originally posted by Omertron on 2009-02-26T16:00:06.000Z:

OK, I know it doesn't show up on the series master yet -- see issue 558.

I could have sworn I saw a TV logo on all individual seasons, but I'll double check
with fresh XML files. Where can I get a "modified up to date" robinsjexcal?

@Omertron
Copy link
Member Author

Comment #5 originally posted by Omertron on 2009-02-26T16:03:59.000Z:

"Where can I get a "modified up to date" robinsjexcal?"

Ask excal! Although it has that other problem we've discussed by PM.

@Omertron
Copy link
Member Author

Comment #6 originally posted by Omertron on 2009-02-26T16:20:50.000Z:

Doesn't matter what skin it is. The logo is drawn onto the poster at generation time.
If you have the logoHD and logoTV settings on in the skin.properties they should
get added to the poster and thumbnails

@Omertron
Copy link
Member Author

Comment #7 originally posted by Omertron on 2009-03-01T04:10:42.000Z:

OK, there are two parts to this.

  1. The series master is not marked as a TV series. This is part of issue 558.
  2. The first season reportedly does not get marked with the TV logo. I have tried several times and cannot
    duplicate this.
  3. Season 0 (ie, "Specials") do not get a TV logo. (This hasn't been mentioned yet in this thread, but it's
    something I've noticed while testing for # 2.)

Can you double-check for me, garp or Gordon, that you're still experiencing this problem, and that you
didn't just need to regenerate your files? (I know, that's like asking you to check that the power's on, but
still. :) Or can someone else chime in and let me know if they can duplicate and how?

@Omertron
Copy link
Member Author

Comment #8 originally posted by Omertron on 2009-03-01T04:11:20.000Z:

Dang it, "Three parts". :)

@Omertron
Copy link
Member Author

Comment #9 originally posted by Omertron on 2009-03-01T08:20:32.000Z:

Ok, if you have multiple seasons of a show and the single series flag is on, then the
poster that is displayed on the index doesn't have tv/hd flags on it.

If you have one season, then the poster in the index DOES have the flags on it.

@Omertron
Copy link
Member Author

Comment #10 originally posted by Omertron on 2009-03-01T13:35:59.000Z:

OK... but all of the seasons inside the single series page get marked as "TV" (except for season 0), right?

@Omertron
Copy link
Member Author

Comment #11 originally posted by Omertron on 2009-03-01T16:51:49.000Z:

Yes, correct. However, I think that the TV show flag should be present on the single
series page to indicate that it is a tv show :)

@Omertron
Copy link
Member Author

Comment #12 originally posted by Omertron on 2009-03-01T17:08:06.000Z:

Yeah, but I'm considering that part of issue 558, which talks about how to attach properties (genres,
top250, isTVShow, etc) to the master in a more general way. TV series are "easy" because the series
seasons don't really have different properties from the master (same title, same genres, same everything),
but I want to handle sets and series all with the same code (as much as possible).

I've actually already got this fixed in my working copy -- just working out a few kinks in the less-straight-
forward stuff.

@Omertron
Copy link
Member Author

Comment #13 originally posted by Omertron on 2009-03-03T03:10:27.000Z:

I think this is now fixed. Could you check r780, please?

@Omertron
Copy link
Member Author

Comment #14 originally posted by Omertron on 2009-03-04T08:07:32.000Z:

r780 seems to work now. TV logo on series page and each individual season poster inside.

@Omertron
Copy link
Member Author

Comment #15 originally posted by Omertron on 2009-03-04T18:42:22.000Z:

How about the HD logo? It required a bit more work/changes.

@Omertron
Copy link
Member Author

Comment #16 originally posted by Omertron on 2009-03-04T23:56:27.000Z:

Yes, looks ok as well.
I do have one example of a TV series that has 2 seasons, where the first one is HD
and the second is not (current season).
The series poster and season 1 poster show HD/TV logos, and season 2 only shows TV,
all as expected.

@Omertron
Copy link
Member Author

Comment #17 originally posted by Omertron on 2009-03-05T01:50:20.000Z:

OK, good. If two or more seasons were HD, the master should also show as HD. I'm marking this fixed.
Thanks garp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant