Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtitles download feature for Sratim plugin #794

Closed
Omertron opened this issue Mar 15, 2015 · 3 comments
Closed

Subtitles download feature for Sratim plugin #794

Omertron opened this issue Mar 15, 2015 · 3 comments

Comments

@Omertron
Copy link
Member

Original issue 795 created by Omertron on 2009-05-19T10:21:21.000Z:

Attach is an update to Sratim plugin that includes automatic subtitles
download from Sratim web site.

The OpenSubtitles.org site does not function very well these days, and many
of the subtitles exist only on Sratim Hebrew web site.

I added automatic subtitles download, that includes login cookies handling,
and zip stream handling. The subtitle functionality is similar to
opensubtitles plugin.

New fields were added in the configuration file "moviejukebox.properties"
to select subtitles download feature, and specify Sratim site login
information.

The subtitles are selected based on file name and frames per second
information. To support the frame per second selection, the plugin needs to
know the FPS of the media file. For these to work I changed the order of
the scan in "MovieJukebox.java".
The media info is collected now before running the plugin instead of after.
I see only positive affect of this change.

See attached file.

@Omertron
Copy link
Member Author

Comment #1 originally posted by Omertron on 2009-05-19T20:10:00.000Z:

Will commit when the project is open again

@Omertron
Copy link
Member Author

Comment #2 originally posted by Omertron on 2009-07-17T06:06:09.000Z:

hi amityony
i can't seem to make the sratim subtitle download to work
do you have to use the sratim plugin in order fro it to work or just writing "true"
next to the sratim subtitles plugin and user pass is enough?

thanks

@Omertron
Copy link
Member Author

Comment #3 originally posted by Omertron on 2009-07-17T10:51:10.000Z:

Yes, you must use the sratim plugin as default plugin in order to use the automatic subtitle download.

You can always use the opensubtitles plugin instead with imdb, if you don't wish to use sratim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant