Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some SD content is erroneously flagged as HD #987

Closed
Omertron opened this issue Mar 15, 2015 · 5 comments
Closed

Some SD content is erroneously flagged as HD #987

Omertron opened this issue Mar 15, 2015 · 5 comments

Comments

@Omertron
Copy link
Member

Original issue 988 created by Omertron on 2009-09-10T04:01:46.000Z:

Any files containing 768x576 or 1024x576 (PAL) content are flaged as HD.

The following change needs to be applied to fix this:

in MediaInfoScanner.java
line 385:
Code:
} else if (width > 720) {
should be:
Code:
} else if (width > 1024) {

@Omertron
Copy link
Member Author

Comment #1 originally posted by Omertron on 2009-09-13T18:37:20.000Z:

Thanks for spotting this.

1080i/p should be width >=1920 and 720p should be width >=1280

Fixed in r1104

@Omertron
Copy link
Member Author

Comment #2 originally posted by Omertron on 2009-09-14T03:59:51.000Z:

Actually I don't think the way you changed is is correct, as it doesn't take into
account cropped media files (where they have removed 20/30/50 or so pixels on each
side to remove any small black borders).
I think the way it was before was most accurate, just with the SD fix I suggested.
width > 1024 = HD720p (no 1280 will be cropped down to less than 1024 and 1024 is the
maximum that SD content could be wide)
width > 1280 = HD1080p (anything bigger than 1280 has to be 1080p as 720p can't be
wider than 1280)

@Omertron
Copy link
Member Author

Comment #3 originally posted by Omertron on 2009-09-14T06:26:10.000Z:

If you've cropped the sides from 1280/1920 then you aren't getting HD really are you?

This method is consistent with the rest of YAMJ where SD < 1280, 720 <1920 and 1080 =
1920

@Omertron
Copy link
Member Author

Comment #4 originally posted by Omertron on 2009-09-14T10:30:59.000Z:

You probably misunderstood me, I didn't mean cropped 720p which is 16/9 all the way
down to 4/3 or so, I meant it's common for reencoded stuff to crop the small black
borders you sometimes get on movies on the sides to save space, so a 1280x720 would
become 1232x694 for example, this is still HD as before, as all the picture
information is still there, only the small black borders have been omitted.

@Omertron
Copy link
Member Author

Comment #5 originally posted by Omertron on 2009-09-14T18:56:58.000Z:

Ah, I understand now. I've updated the MediaInfo Scanner now in r1108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant