Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory leaking #772

Closed
xcccdjsn opened this issue Nov 2, 2024 · 8 comments
Closed

memory leaking #772

xcccdjsn opened this issue Nov 2, 2024 · 8 comments
Labels
bug Something isn't working

Comments

@xcccdjsn
Copy link

xcccdjsn commented Nov 2, 2024

I have used swaylock, hyprlock and gtklock, but all of them will increment memory amount every time after using it.

System Information

  • niri version: niri 0.1.9 (unknown commit)
  • Distro: Arch Linux x86_64
  • GPU: Intel UHD Graphics G4 @ 1.25 GHz [Integrated]
  • CPU: 11th Gen Intel(R) Core(TM) i3-1115G4 (4) @ 4.10 GHz
@xcccdjsn xcccdjsn added the bug Something isn't working label Nov 2, 2024
@YaLTeR
Copy link
Owner

YaLTeR commented Nov 2, 2024

Could it be some mesa GPU objects that will get garbage collected later?

I guess we need to check with the Tracy memory profiler or something to see if there are any leaks on the Rust side.

@YaLTeR
Copy link
Owner

YaLTeR commented Nov 2, 2024

I added Tracy profiling. I can see the Rust memory increase every time I run swaylock. It's a bit hard to tell what gets leaked. Seems like some surface data might have a ref cycle?

@YaLTeR
Copy link
Owner

YaLTeR commented Nov 2, 2024

Found it: Smithay/smithay#1573

@xcccdjsn
Copy link
Author

xcccdjsn commented Nov 2, 2024

I have not test other window manager.

I found other application also can cause memory leaking, especially kitty. Spawn multiple kitty in short time, and then close them quickly. I did it many times resulting in lot of memory leaking.

This is my result screenshots.
I also got memory usage from btop which derived same result.

IMG20241102193500
IMG20241102193516
IMG20241102193539

@GallowsDove
Copy link

GallowsDove commented Nov 2, 2024

That is exactly what I've been rambling about in matrix room a few weeks ago. Recommend looking at my smithay issue and other linked issues.

Smithay/smithay#1562

@YaLTeR
Copy link
Owner

YaLTeR commented Nov 2, 2024

Screen locker leak should be fixed with 600cffb

@YaLTeR
Copy link
Owner

YaLTeR commented Nov 6, 2024

@xcccdjsn could you please test cosmic-comp for your kitty issue? I believe it's not niri specific and there's already a Smithay issue open.

@YaLTeR
Copy link
Owner

YaLTeR commented Nov 8, 2024

Gonna close this assuming it's the Smithay issue.

@YaLTeR YaLTeR closed this as completed Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants