Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved scan performance #93

Merged
merged 3 commits into from
May 10, 2024
Merged

Conversation

kirillgarbar
Copy link
Contributor

@kirillgarbar kirillgarbar commented Mar 24, 2024

Proposed Changes

Exclude scan is rewritten so it uses less kernel calls and no cycles outside of kernels.
Other versions of scan left unchanged because they are rarely used and may be reworked later so I can focus on further performance analysis.
We also had two Common.PrefixSum modules and it was confusing if we are using api module or internal one.
New scan code looks so unusual because we can't directly use recursion and compile time kernel translation at the same time.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

@@ -209,6 +209,7 @@ module PrefixSum =
let runBackwardsIncludeInPlace plus = runInPlace plus true scanInclusive

/// <summary>
/// This method is deprecated due to bad perfomance.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use obsolete attribute here?

@kirillgarbar kirillgarbar merged commit 108c45c into SparseLinearAlgebra:dev May 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants