Skip to content
This repository has been archived by the owner on Jun 30, 2021. It is now read-only.

Create a unified ownership trie. #9

Closed
NathanFrench opened this issue May 23, 2017 · 2 comments
Closed

Create a unified ownership trie. #9

NathanFrench opened this issue May 23, 2017 · 2 comments

Comments

@NathanFrench
Copy link
Collaborator

NathanFrench commented May 23, 2017

There is no real regulation other than take_ownership that allows for a user to specify who owns what (e.g., who opens and closes a file descriptor).

See initial discussion: #6

Cascading the structures and adding a flag would be optimal:

struct socket {
   int flags; (EVHTP_SOCK_OWNER)
   int sock;
};

struct evhtp {
    int flags; (EVHTP_FLAG_OWNER)
    struct socket socket;
     ...
};

struct connection {
   int flags; (EVHTP_CONN_FLAG_OWNER)
   ...
};

struct request {
   int flags; (EVHTP_REQ_FLAG_OWNER)
   ...
};
@NathanFrench
Copy link
Collaborator Author

NathanFrench commented May 23, 2017

Added https://github.com/criticalstack/libevhtp/compare/merge-flags branch to track this.

@NathanFrench NathanFrench changed the title [TODO] Create a unified ownership trie. Create a unified ownership trie. May 23, 2017
@NathanFrench NathanFrench self-assigned this May 23, 2017
@NathanFrench NathanFrench changed the title Create a unified ownership trie. Create a unified ownership trie. (ping #6) May 23, 2017
@NathanFrench NathanFrench changed the title Create a unified ownership trie. (ping #6) Create a unified ownership trie. (ping issue#6) May 23, 2017
@NathanFrench NathanFrench changed the title Create a unified ownership trie. (ping issue#6) Create a unified ownership trie. May 23, 2017
@NathanFrench NathanFrench added this to the 1.1.12 release milestone May 24, 2017
@NathanFrench
Copy link
Collaborator Author

#12 addresses half of the fun - going to merge this part if nobody has a problem.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant