Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings-UI: fix add profile accessibility #19757

Merged
merged 2 commits into from
Feb 1, 2023

Conversation

vraja-pro
Copy link
Contributor

@vraja-pro vraja-pro commented Jan 30, 2023

Context

  • Change focus after adding new profile to the new input.
  • Add aria-label to the delete/Trash icon.

Summary

This PR can be summarized in the following changelog entry:

  • Improves accessibility for the extra other profiles in the Settings' Site representation when Organization is selected.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Open YoastSEO->Settings->Site representation
  • Select Organization in Organization/person
  • Scroll down to Other profiles
  • Click on Add another profile
  • Check focus is on the new input field for the profile.
  • Turn on screen reader and use tab to move to the Add another profile, click on it
  • Use tab to reach the Trash icon to delete the profile. Check the description is clear: 'Remove Other profile...`

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Block/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label and noted the work hours.

Fixes nother profile' feature#19541

* Added aria label to the remove button
* added focus of input of profile that is added
@vraja-pro vraja-pro added UI change PRs that result in a change in the UI changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog labels Jan 30, 2023
Copy link
Member

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🏗️

Copy link
Member

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR && AC ✅

@igorschoester igorschoester merged commit 74daefb into trunk Feb 1, 2023
@igorschoester igorschoester deleted the 19541-improve-add-another-profile-feature branch February 1, 2023 11:11
@igorschoester igorschoester added this to the 20.2 milestone Feb 1, 2023
@vraja-pro vraja-pro added changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog and removed changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog labels Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog UI change PRs that result in a change in the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve 'Add another profile' feature
2 participants