Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scale-2 branch not maintained, broken on Minikube 0.25.2 #169

Closed
ldcasillas-progreso opened this issue Apr 10, 2018 · 1 comment
Closed

Comments

@ldcasillas-progreso
Copy link

I upgraded Minikube from 0.25.0 to 0.25.2 and the scale-2 branch stopped working. Rather than bother with the technical details of the failure (which I didn't fully investigate), there's a simpler observation to be made: the scale-2 branch is behind master by a couple of months, and simply rebasing scale-2 on top of the latest master fixed it.

I could submit a pull request bringing it up to date, but it sounds to me like this situation calls first and foremost for a policy decision—either the single-node and scale-2 branches should be actively maintained, or the README should stop directing users to try them and instead document some supported procedure for running a smaller cluster (which could be as simple as instructions on what files to edit to scale the cluster down).

@solsson
Copy link
Contributor

solsson commented Apr 11, 2018

I just need a reminder now and then :) Rebased now, thanks.

There's some thoughs of mine about the maintenance situation in #44 (comment). I'd be happy to point the readme to forks instead of branches.

@solsson solsson closed this as completed Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@solsson @ldcasillas-progreso and others