Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect JSX syntax highlighting with Babel #23

Open
thawsitt opened this issue Jul 19, 2018 · 4 comments
Open

Incorrect JSX syntax highlighting with Babel #23

thawsitt opened this issue Jul 19, 2018 · 4 comments

Comments

@thawsitt
Copy link

thawsitt commented Jul 19, 2018

I have this issue when I open a .jsx file using Babel ES6 Javascript selected as the language.

I believe text like "Welcome to React" should be white instead of green.

Imgur

@thawsitt thawsitt changed the title Support JSX syntax highlighting Incorrect JSX syntax highlighting with Babel Jul 19, 2018
@noudadrichem
Copy link
Collaborator

Hi @thawsitt ,

The text should indeed be white, thanks for making an issue out of this. I'm using the React package myself which also uses JSX, and that goes fine. I will check where this goes wrong and update you soon!

@noudadrichem
Copy link
Collaborator

May I ask why you're using a 3rd party syntax highlighter for ES6? Atom supports this by default. JSX is the only thing that needs an extra package.

@thawsitt
Copy link
Author

Hi @noudadrichem,

I am using language-babel package because I want atom to support JSX syntax on .js files. (as recommended by React). One Dark syntax theme seems to work fine in this case, but city-lights is still my favorite. 😊

@noudadrichem
Copy link
Collaborator

Haha glad you like it! I'll take a look at this! Should be a small change. I'm using the React package (https://atom.io/packages/react) which works fine with JSX. Maybe you can use it in the mean time😊😊

I'll keep you up to date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants