Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please update pod for ios 14 #572

Closed
fukemy opened this issue Sep 23, 2020 · 6 comments
Closed

please update pod for ios 14 #572

fukemy opened this issue Sep 23, 2020 · 6 comments
Labels
Crash The picker crashes ! Xcode12 / iOS14

Comments

@fukemy
Copy link

fukemy commented Sep 23, 2020

after update ios14, i got this error

Screen Shot 2020-09-23 at 20 29 16

@almet88
Copy link

almet88 commented Sep 24, 2020

#563 this helps, but generally, pod needs to be updated, it crashes when user cancels selection and Apple Review team says that it crashes, but I can't find where.

@fukemy
Copy link
Author

fukemy commented Sep 24, 2020

@almet88 use firebase analystic to check problem bro

@almet88
Copy link

almet88 commented Sep 24, 2020

It crashes on line 183 in file YPLibraryVC if user does not give access to any photo in Limited photo access mode.

@fukemy
Copy link
Author

fukemy commented Sep 24, 2020

i think u can request permission before using library each time

@almet88
Copy link

almet88 commented Sep 24, 2020

Yes, but it crashes if user gives LIMITED permission, then iOS 14 shows him his gallery to choose photos that he allows app to use and if user doesn't choose any photo, app crashes since it tries to create the asset from the first photo from library (I think for preview or smth like that)

@NikKovIos NikKovIos added the Crash The picker crashes ! label Sep 25, 2020
@NikKovIos
Copy link
Collaborator

Crash reproduced only with defaultMultipleSelection == true.
Fixed 89acc4c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crash The picker crashes ! Xcode12 / iOS14
Projects
None yet
Development

No branches or pull requests

4 participants